Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-8484

comp: assorted bugs

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.0
    • None
    • Operating System: ReactOS
      Platform: x86 Hardware

    Description

      Created an attachment (id=5993)
      correcting some bugs in cmdutils/comp

      Bugs in order:
      1) Memory leak,
      lines 63, 64 buffers Line1, Line2 are not freed.
      2) Access violation bug when comparing files with size > STRBUF=1024 bytes.
      line 169 - Line1, Line2 are incremented, and in GetLine - write outside
      these buffers.
      3) Incorrect algorithm of comparing - lines 158-171.
      One of files can have more lines than another or more
      chars on line than another but it says: Files compare OK.

      I've attached patch, that corrects all these bugs.
      Also implemented options /A /L, that were not supported.

      Attachments

        Activity

          People

            Z98 Z98
            kruntuid kruntuid
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: