Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-8952

sysdm.cpl: Issues with the startup and recovery options dialog

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: 0.4.0
    • Component/s: RosDlls
    • Labels:

      Description

      If the registry key where the crash control settings are saved does not exist or opening this key fails for
      some other reason, the releated dialog parts behave as they where not implemented (settings are not
      saved, empty dump type list).

      The attached patch does the following:

      • In Load/WriteStartupRecoveryOptions, use RegCreateKeyEx instead of RegOpenKeyEx.
      • Save the return value from RegCreateKeyEx to a variable. In case of an error, use SetLastError
        to set the last error to this return value and call ShowLastWin32Error to inform the user about the
        error.
      • If RegCreateKeyEx fails in LoadStartupRecoveryOptions, disable the related GUI elements and
        don't try to safe the releated settings if the user hits ok.
      • Also replace a LoadString with LoadStringW, since all other places use explicitly the unicode functions.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ekohl ekohl
                Reporter:
                Forever Winter Forever Winter
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: