Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-9884

[WIN32SS/(kbswitch)] CheckMenuItem() menu index off by one!!! PATCH

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.0
    • Win32SS
    • ros TRUNK r68283

    Description

      win32ss\user\ntuser\menu.c::990
      IntCheckMenuItem(PMENU MenuObject, UINT uIDCheckItem, UINT uCheck)

      has an OFF-BY-ONE issue in IN-parameter 'uIDCheckItem':
      when calling
      (void)CheckMenuItem(hMenu, 2, MF_CHECKED);

      When you call this on Windows, the second item in the menu is checked (correct)
      When you call this on ROS, the first item in the menu is checked (wrong)

      I verified that by a cross test!

      -----------------
      You can see this symptom in ros-kbswitch-tool when checking active keyboard layout!
      Works on Windows, but always sets the checkbox off-by-one in ros

      base\applications\kbswitch\kbswitch.c::328
      calls (void)CheckMenuItem(hMenu, ulCurrentLayoutNum, MF_CHECKED);

      Attachments

        Issue Links

          Activity

            People

              jimtabor jimtabor
              reactosfanboy reactosfanboy
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: