Details
-
Bug
-
Resolution: Fixed
-
Major
-
None
-
None
Description
Right now our Testman is always linking the Log results to /rostests/winetests even if the test were an apitests one. As a result, links in apitetest logs are never pointing to the proper folder and fail to open.
One tiny example:
https://reactos.org/testman/detail.php?id=29725997&prev=29725132
In detail.php we have the logic already set to find if the test file belongs to the winetests or to the apitests folder by using a get_headers request to winetest folder first, and if the header returned is 'HTTP/1.1 404 Not Found', then it tries requesting to the apitests one.
The current logic:
$search_urls = array("rostests/winetests", "rostests/apitests");
foreach ($search_urls as $surl)
The logic is perfect but seems to not be working. Why?
Since VIEWVC_TRUNK is defined as "http://svn.reactos.org/svn/reactos" when we perform the first get_headers call to the winetests folder, and in the case the file doesn't belong to it, the header is not returning a 404 as expected but a "HTTP/1.1 301 Moved Permanently" due the http->https redirection. Since our logic is based in failure when 404 then the "continue" is never executed and hence we are always returning the winetests path.
The patch is easy:
Defining VIEWVC_TRUNK as "http*s*://svn.reactos.org/svn/reactos" instead.
This way we jump the redirection and we can rely in the 404 header.
Just a letter to fix Testman
Attachments
Issue Links
- blocks
-
ONLINE-636 PATCH: Fix Kmtests, Win32knt, crtdll_crt, ntdll_crt, msvcrt_crt log links in Testman
- Open
- is duplicated by
-
ONLINE-578 Testman does not link to svn correctly.
- Closed