Uploaded image for project: 'ReactOS Build Environment'
  1. ReactOS Build Environment
  2. ROSBE-7

Incorrect address precalculation in raddr2line scripts

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • RosBE-Windows
    • None
    • Operating System: ReactOS
      Platform: x86 Hardware

    Description

      Created an attachment (id=4480)
      Fixes (removes) address precalculation

      See CORE-4011 and r44515 (trunk/reactos):
      This address pre-calculation is now obsolete and incorrect:

      :: First get the ImageBase of the File. If its smaller than the given
      :: Parameter, everything is ok, because it was already added onto the
      :: adress and can be given directly to raddr2line. If not, add it and
      :: give the result to raddr2line.
      echo %FILEPATH%

      for /f "tokens=2" %%i in ('"objdump -p "%FILEPATH%" 2>NUL | findstr ImageBase"') do set BASEADDRESS=0x%%i

      if %%i lss %ADDRESS% (
      "%_ROSBE_BASEDIR%\Tools\raddr2line.exe" "%FILEPATH%" "%ADDRESS%"
      ) else (
      set /a BASEADDRESS+=0x%ADDRESS%

      for /f %%i in ('""%_ROSBE_BASEDIR%\Tools\echoh.exe" Unable to render embedded object: File (BASEADDRESS) not found."') do set RELBASE=%%i
      "%_ROSBE_BASEDIR%\Tools\raddr2line.exe" "Unable to render embedded object: File (FILEPATH) not found." "Unable to render embedded object: File (RELBASE) not found."
      )

      Attachments

        Activity

          People

            bug zilla Bug Zilla
            jansssens Jan Roeloffzen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: