ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-206

iphlpapi_winetests incorrectly redefine htonl

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:

      Description

      Our iphlpapi_winetests has the following block of code (which is not in Wine):

      #undef htonl
      #undef htons
      #undef ntohl
      #undef ntohs
       
      #define htonl(l) ((u_long)(l))
      #define htons(s) ((u_short)(s))
      #define ntohl(l) ((u_long)(l))
      #define ntohs(s) ((u_short)(s))
      

      These functions are incorrectly redefined, breaking some tests.

        Activity

        Hide
        HBelusca
        added a comment -

        With svn "blame" command, can you see why these extra lines where introduced?

        Show
        HBelusca
        added a comment - With svn "blame" command, can you see why these extra lines where introduced?
        Hide
        Tim
        added a comment -

        Introduced in r40949 (2009-05-17) by dchapyshev: Sync wine tests with Wine 1.1.21

        Show
        Tim
        added a comment - Introduced in r40949 (2009-05-17) by dchapyshev: Sync wine tests with Wine 1.1.21
        Hide
        Tim
        added a comment -

        Patch to correct the redefinitions. This allows all tests to pass on Windows.

        Show
        Tim
        added a comment - Patch to correct the redefinitions. This allows all tests to pass on Windows.
        Hide
        Amine Khaldi
        added a comment -

        Fixed in r70270. All tests pass on Windows 2k3 SP2.

        Show
        Amine Khaldi
        added a comment - Fixed in r70270. All tests pass on Windows 2k3 SP2.
        Hide
        Tim
        added a comment - - edited

        Linking to ws2_32 seems to have broken testIcmpSendEcho (and only that) on ReactOS.

        iphlpapi.c:950: Tests skipped: ICMP is not available.
        

        Show
        Tim
        added a comment - - edited Linking to ws2_32 seems to have broken testIcmpSendEcho (and only that) on ReactOS. iphlpapi.c:950: Tests skipped: ICMP is not available.
        Hide
        Amine Khaldi
        added a comment -

        Nothing regressed as we didn't have system ping functionality working in the first place.

        Show
        Amine Khaldi
        added a comment - Nothing regressed as we didn't have system ping functionality working in the first place.
        Hide
        Tim
        added a comment -

        Not sure what you mean.

        Linking to ws2_32 caused the call to socket in IcmpCreateFile to fail with WSANOTINITIALISED. IcmpCreateFile then returns ERROR_ACCESS_DENIED and these tests are skipped.

        Show
        Tim
        added a comment - Not sure what you mean. Linking to ws2_32 caused the call to socket in IcmpCreateFile to fail with WSANOTINITIALISED . IcmpCreateFile then returns ERROR_ACCESS_DENIED and these tests are skipped.

          People

          • Assignee:
            Amine Khaldi
            Reporter:
            Tim
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: