ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-209

Some shell32_winetest:shelldispatch tests are skipped

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.1
    • Component/s: Wine Tests
    • Labels:

      Description

      test_ShellFolderViewDual(), test_ShellWindows(), test_ParseName() and test_Verbs() are skipped due to lack of the related classes.

      1. CDefViewDual.patch
        8 kB
        Mark Jansen
      2. CDefViewDual.patch
        9 kB
        Mark Jansen
      3. CShell.patch
        49 kB
        Mark Jansen
      4. CShell.patch
        18 kB
        Mark Jansen
      5. final.patch
        22 kB
        Mark Jansen
      6. shell32_typelib.patch
        3 kB
        Mark Jansen
      7. shelldispatch.c.patch
        0.8 kB
        Mark Jansen

        Issue Links

          Activity

          Hide
          Thomas Faber
          added a comment -

          Do any of your patches depend on registering the typelib? I.e. does CORE-11104 and shell32_typelib.patch have to come before CDefViewDual, or before the updated CShell patch you mentioned?

          Any particular reason CDefViewDual is implemented inline rather than having a header file like most other classes seem to?

          Thanks.

          Show
          Thomas Faber
          added a comment - Do any of your patches depend on registering the typelib? I.e. does CORE-11104 and shell32_typelib.patch have to come before CDefViewDual, or before the updated CShell patch you mentioned? Any particular reason CDefViewDual is implemented inline rather than having a header file like most other classes seem to? Thanks.
          Hide
          Thomas Faber
          added a comment -

          Regarding test_ShellWindows... it was probably just included because it's in the middle

          Show
          Thomas Faber
          added a comment - Regarding test_ShellWindows... it was probably just included because it's in the middle
          Hide
          Mark Jansen
          added a comment -

          The next patch (that comes ontop of CDefViewDual.patch and CShell.patch) will glue them together, and for the functionality to also work the typelib needs to be registered.
          Otherwise the CShell object cannot acces it's own type info

          CDefViewDual is implemented inline because no other class needs to know about it's implementation, they only know it by one of the base classes. (and maybe because it was less typing )

          Show
          Mark Jansen
          added a comment - The next patch (that comes ontop of CDefViewDual.patch and CShell.patch) will glue them together, and for the functionality to also work the typelib needs to be registered. Otherwise the CShell object cannot acces it's own type info CDefViewDual is implemented inline because no other class needs to know about it's implementation, they only know it by one of the base classes. (and maybe because it was less typing )
          Hide
          Mark Jansen
          added a comment -

          CDefViewDual.patch committed.

          Show
          Mark Jansen
          added a comment - CDefViewDual.patch committed.
          Hide
          Mark Jansen
          added a comment - - edited

          The result after shell32_typelib.patch:
          (Ran it twice)
          https://www.reactos.org/testman/compare.php?ids=47507,47508,47509

          Most COM related tests seem to improve, however kernel32:directory takes a big hit...

          edit:
          47507 has a canceled test, which throws the rest off.

          better comparison is:
          https://www.reactos.org/testman/compare.php?ids=47506,47508,47509

          Show
          Mark Jansen
          added a comment - - edited The result after shell32_typelib.patch : (Ran it twice) https://www.reactos.org/testman/compare.php?ids=47507,47508,47509 Most COM related tests seem to improve, however kernel32:directory takes a big hit... edit: 47507 has a canceled test, which throws the rest off. better comparison is: https://www.reactos.org/testman/compare.php?ids=47506,47508,47509

            People

            • Assignee:
              Mark Jansen
              Reporter:
              Amine Khaldi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile