ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-214

iphlpapi_apitest:icmp Add tests for other Icmp* functions

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: ReactOS Tests
    • Labels:

      Description

      Tests for my icmp.c rewrite.

      test_IcmpSendEcho supersedes testIcmpSendEcho in iphlpapi_winetest.

      1. icmp_tests.patch
        28 kB
        Tim
      2. icmp_tests.patch
        29 kB
        Mark Jansen
      3. icmp_tests.patch
        29 kB
        Mark Jansen

        Issue Links

          Activity

          Hide
          Tim
          added a comment -

          Same reason, different places: the Wine code doesn't handle NULL. This patch disables tests that will currently crash iphlpapi:icmp.

          Show
          Tim
          added a comment - Same reason, different places: the Wine code doesn't handle NULL. This patch disables tests that will currently crash iphlpapi:icmp .
          Hide
          Tim
          added a comment -

          Looks like I missed something; I had some local changes.

          Show
          Tim
          added a comment - Looks like I missed something; I had some local changes.
          Hide
          Mark Jansen
          added a comment -
          Show
          Mark Jansen
          added a comment - The latest patch also crashes: https://www.reactos.org/testman/compare.php?ids=48674,48675
          Show
          Mark Jansen
          added a comment - https://www.reactos.org/testman/compare.php?ids=48698,48701
          Hide
          Amine Khaldi
          added a comment -

          On my 2k3 I get:

          icmp: 67 tests executed (0 marked as todo, 0 failures), 5 skipped.
          

          Show
          Amine Khaldi
          added a comment - On my 2k3 I get: icmp: 67 tests executed (0 marked as todo, 0 failures), 5 skipped.

            People

            • Assignee:
              Bug Zilla
              Reporter:
              Tim
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: