Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: ReactOS Tests
    • Labels:

      Description

      Tests for SetComputerNameExW() showing a non-so-critical bug in ReactOS.

      1. kernel32.patch
        6 kB
        victor martinez calvo

        Activity

        Hide
        victor martinez calvo
        added a comment -

        I found a little issue...so in progress.
        Somehow the Nv hostname is created somewhen by Ros. I want to find whats happening(maybe it is created after SetComputerNameExW call?)

        Show
        victor martinez calvo
        added a comment - I found a little issue...so in progress. Somehow the Nv hostname is created somewhen by Ros. I want to find whats happening(maybe it is created after SetComputerNameExW call?)
        Hide
        Mark Jansen
        added a comment -

        victor martinez calvo: Tried contacting you in irc a few times, but i guess that didnt work

        For the file: please use utf-8 without a BOM.
        In case something fails halfway down the test, you do not close handles or restore previous values.
        Instead of bailing out when a read fails, you might wanna just skip the test that it's for. (Optionally adding a skip("") warning the user that a read failed, thus that he might need to run the test as admin).

        Show
        Mark Jansen
        added a comment - victor martinez calvo : Tried contacting you in irc a few times, but i guess that didnt work For the file: please use utf-8 without a BOM. In case something fails halfway down the test, you do not close handles or restore previous values. Instead of bailing out when a read fails, you might wanna just skip the test that it's for. (Optionally adding a skip("") warning the user that a read failed, thus that he might need to run the test as admin).

          People

          • Assignee:
            Bug Zilla
            Reporter:
            victor martinez calvo
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: