ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-243

[PATCH] Add tests for kernel32 GetComputerNameEx return values

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 0.4.3
    • Component/s: ReactOS Tests
    • Labels:
    • Sprint:
      September 2016
    • Guilty Revision:
      72,722

      Description

      Add tests that prove that my last change in kernel32 GetComputerNameEx (r72722) is wrong.
      I should have implemented it in a different way and this change should be reverted.
      Also it proves that ComputerNameNetBIOS/ComputerNamePhysicalNetBIOS type return value is read from wrong place.

        Issue Links

          Activity

          Hide
          Amine Khaldi
          added a comment -

          Test results on 2k3: GetComputerNameEx: 365 tests executed (0 marked as todo, 0 failures), 0 skipped.

          Show
          Amine Khaldi
          added a comment - Test results on 2k3: GetComputerNameEx: 365 tests executed (0 marked as todo, 0 failures), 0 skipped.
          Show
          Amine Khaldi
          added a comment - Test results: https://reactos.org/testman/compare.php?ids=49324,49330
          Hide
          hater
          added a comment -

          Proper fix after 72722 is reverted.

          Show
          hater
          added a comment - Proper fix after 72722 is reverted.
          Hide
          hater
          added a comment -

          Atomic patch to revert 72722 and apply the fix it in iphlpapi

          Show
          hater
          added a comment - Atomic patch to revert 72722 and apply the fix it in iphlpapi
          Hide
          Amine Khaldi
          added a comment -

          Committed the tests and the fix in r72849 and r72851. Cheers.

          Show
          Amine Khaldi
          added a comment - Committed the tests and the fix in r72849 and r72851. Cheers.

            People

            • Assignee:
              Amine Khaldi
              Reporter:
              hater
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile