ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-246

Create Test for WSAIoctl / SIO_GET_INTERFACE_LIST (0x4004747f)

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.3
    • Component/s: None
    • Labels:

      Description

      WSHIoctl in wshtcpip.dll is unimplemented in ROS.
      WSAIcotl redirects a call for SIO_GET_INTERFACE_LIST to WSHIoctl.

      For this code it should return a INTERFACE_INFO-List.

      Patch for Test added.

      See also CORE-7944 and CORE-10343.

        Activity

        Hide
        HBelusca
        added a comment -

        Cc hater.

        Show
        HBelusca
        added a comment - Cc hater .
        Hide
        Amine Khaldi
        added a comment -

        Thank you andy-123. Keep up your great work

        Show
        Amine Khaldi
        added a comment - Thank you andy-123 . Keep up your great work
        Hide
        hater
        added a comment -

        andy-123 Hey. Thanks for the patch. Project can always benefit from more tests. Just few remarks:
        1. Create patches from reactos directory. I know that tests are in rostests outside of it and it needs a bit of work (unfortunately). So in this case you have to create the patch you from trunk and manually add the string "modules/" to the file names in the patch (Sorry for the inconvenience). I can fix that if my description was not good enough.
        2. You first check if GetIpAddrTable is working which is great, but with return FALSE use the macro "skip" to mark the test as skipped instead of failed with "ok(FALSE,...".
        3. Don't use static buffer for taking the info (buf). Allocate it if bytes returned is > 0. On my machine test fails, because I have several adapters and 1k is not enough .
        4. You assume that tables returned by GetIpAddrTable and the ioctl are matching by row. All tests will fail if an adapter position in the table moved. I would suggest to either not check info bit by bit or find a way to match returned row to expected row.

        Show
        hater
        added a comment - andy-123 Hey. Thanks for the patch. Project can always benefit from more tests. Just few remarks: 1. Create patches from reactos directory. I know that tests are in rostests outside of it and it needs a bit of work (unfortunately). So in this case you have to create the patch you from trunk and manually add the string "modules/" to the file names in the patch (Sorry for the inconvenience). I can fix that if my description was not good enough. 2. You first check if GetIpAddrTable is working which is great, but with return FALSE use the macro "skip" to mark the test as skipped instead of failed with "ok(FALSE,...". 3. Don't use static buffer for taking the info (buf). Allocate it if bytes returned is > 0. On my machine test fails, because I have several adapters and 1k is not enough . 4. You assume that tables returned by GetIpAddrTable and the ioctl are matching by row. All tests will fail if an adapter position in the table moved. I would suggest to either not check info bit by bit or find a way to match returned row to expected row.
        Hide
        andy-123
        added a comment -

        Hey hater.
        (Hey Amine Khaldi)
        Sorry for my late reply.
        Thank you for your having a look at it and your comments.
        I will have a look at it and make a new patch in a few days.

        I think i know what you mean with point 1. I will create the new patch from reactos-directory wich has a link to the rostests in modules/rostests. Right?

        Show
        andy-123
        added a comment - Hey hater. (Hey Amine Khaldi) Sorry for my late reply. Thank you for your having a look at it and your comments. I will have a look at it and make a new patch in a few days. I think i know what you mean with point 1. I will create the new patch from reactos-directory wich has a link to the rostests in modules/rostests. Right?
        Hide
        andy-123
        added a comment -

        Hey hater,

        i have attached a new patch. All points you suggested are done

        • I hope the basedir is now correct (/modules/rostest/...)
        • It ueses now skip(... instead of ok(FALSE. Thank you for this hint.
        • The buffer (buf) is now dynamic allocated. I hope its enough for your pc
        • Both tables will be sorted by ip. So comparing bit by bit should be okay.
        Show
        andy-123
        added a comment - Hey hater, i have attached a new patch. All points you suggested are done I hope the basedir is now correct (/modules/rostest/...) It ueses now skip(... instead of ok(FALSE. Thank you for this hint. The buffer (buf) is now dynamic allocated. I hope its enough for your pc Both tables will be sorted by ip. So comparing bit by bit should be okay.
        Hide
        hater
        added a comment -

        Committed in r73011
        Thanks

        Show
        hater
        added a comment - Committed in r73011 Thanks

          People

          • Assignee:
            hater
            Reporter:
            andy-123
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile