ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-251

Adapt/Fix rostests/winetests/kernel32/generated.c so it can be enabled

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Wine Tests
    • Labels:

      Description

      See r70802 (by Sylvain Petreolle) that reads

      The kernel32 generated remains disabled,
      Wine's definition of COMMCONFIG differs from our/MSDN definition.
      Commented out nonexisting LPEXCEPTION_RECORD.
      

      Hopefully, we can gain some more test coverage out of it.

        Activity

        Hide
        Serge Gautherie
        added a comment -

        PS: I'm trying to email "Wine" to discuss why they define it differently.

        I'm talking to someone, but no technical answer yet.

        Show
        Serge Gautherie
        added a comment - PS: I'm trying to email "Wine" to discuss why they define it differently. I'm talking to someone, but no technical answer yet.
        Hide
        Serge Gautherie
        added a comment -

        1 reboot extra + some shit was crashed.

        I guessed so, thanks for the confirmation.

        ROSTESTS-251_kernel32_winetests_4BBv2_DisabledDebugger.patch
        4BBv1 patch, with format a bit more like Git (wrt ONLINE-669) and commented out func_debugger.

        Not for commit, just for Testman.

        Show
        Serge Gautherie
        added a comment - 1 reboot extra + some shit was crashed. I guessed so, thanks for the confirmation. ROSTESTS-251_kernel32_winetests_4BBv2_DisabledDebugger.patch 4BBv1 patch, with format a bit more like Git (wrt ONLINE-669 ) and commented out func_debugger. Not for commit, just for Testman.
        Show
        Mark Jansen
        added a comment - It's building https://build.reactos.org/builders/Build%20GCCLin_x86/builds/16724
        Hide
        Serge Gautherie
        added a comment -

        https://reactos.org/testman/compare.php?ids=50742,50744,50745
        r73492 + 4BBv1: 2 "bad run".

        It's building https://build.reactos.org/builders/Build%20GCCLin_x86/builds/16724

        https://reactos.org/testman/compare.php?ids=50746,50747,50749
        r73493 + 4BBv1: 2 "good run".
        (Though I wonder why "Tests performed" keeps on increasing (by thousands).)

        Is this "usual" buildbot/builders instability?
        Otherwise, you may want to try 4BBv2.

        Show
        Serge Gautherie
        added a comment - https://reactos.org/testman/compare.php?ids=50742,50744,50745 r73492 + 4BBv1: 2 "bad run". It's building https://build.reactos.org/builders/Build%20GCCLin_x86/builds/16724 https://reactos.org/testman/compare.php?ids=50746,50747,50749 r73493 + 4BBv1: 2 "good run". (Though I wonder why "Tests performed" keeps on increasing (by thousands).) Is this "usual" buildbot/builders instability? Otherwise, you may want to try 4BBv2.
        Hide
        Serge Gautherie
        added a comment -

        try 4BBv2.

        I believe I have no mean to investigate troubles with 4BBv1.
        Please, try 4BBv2 and commit it if it's good.

        Show
        Serge Gautherie
        added a comment - try 4BBv2. I believe I have no mean to investigate troubles with 4BBv1. Please, try 4BBv2 and commit it if it's good.

          People

          • Assignee:
            Serge Gautherie
            Reporter:
            Serge Gautherie
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: