See r70802 (by Sylvain Petreolle) that reads
The kernel32 generated remains disabled,
Wine's definition of COMMCONFIG differs from our/MSDN definition.
Commented out nonexisting LPEXCEPTION_RECORD.
Hopefully, we can gain some more test coverage out of it.
(MSDN) COMMCONFIG structure
Optional provider-specific data. This member can be of any size or can be omitted. Because the COMMCONFIG structure may be expanded in the future, applications should use the dwProviderOffset member to determine the location of this member.
(Social MSDN) Sizeof COMMCONFIG has changed!
the initialization size of COMMCONFIG is 50 bytes (shown by the debugger), but the call to GetCommConfig returns with the third parameter, lpszSize, updated to 52, indicating that the size of COMMCONFIG has increased.
The single byte array member at the end of the structure (WCHAR
wcProviderData) is normal Windows speak for a variable sized
It's not an API I recall ever using, but I guess you're meant to call
it twice - once to determine how much memory to allocate for the
COMMCONFIG, then again with the allocated area of the correct size.
NB: That's what SDK v7.1 (Win7 + .NetF 4) has (still).
(Wine) add prototypes for serial API functions
PS: I'm trying to email "Wine" to discuss why they define it differently.
I'm only fixing the test as-is.
If needed, someone should further review our ROS+Wine code: COMMCONFIG grep.
I'm talking to someone, but no technical answer yet.
1 reboot extra + some shit was crashed.
I guessed so, thanks for the confirmation.
4BBv1 patch, with format a bit more like Git (wrt ONLINE-669) and commented out func_debugger.
Not for commit, just for Testman.
It's building https://build.reactos.org/builders/Build%20GCCLin_x86/builds/16724
r73492 + 4BBv1: 2 "bad run".
r73493 + 4BBv1: 2 "good run".
(Though I wonder why "Tests performed" keeps on increasing (by thousands).)
Is this "usual" buildbot/builders instability?
Otherwise, you may want to try 4BBv2.
I believe I have no mean to investigate troubles with 4BBv1.
Please, try 4BBv2 and commit it if it's good.