Uploaded image for project: 'ReactOS Test Suite'
  1. ReactOS Test Suite
  2. ROSTESTS-385

Allow wine ws2_32:sock regression test to complete

    XMLWordPrintable

Details

    Description

      Attention: ws2_32:sock test does cause failures even on 2k3sp2 WHS bot, which means the test itself is not correct: https://reactos.org/testman/compare.php?ids=89609

      additionally to that it causes real crashes when run under ros:
      For some time the ws2_32:sock winetest has not provided testbot results due to two different hangs. See (https://reactos.org/testman/compare.php?ids=60023,60025). These two tests are part of the sock.c test and are as follows:

      1) test_write_watch
      2) test_ConnectEx

      For the first one, it depends upon some as yet unimplemented MEM_WRITE_WATCH functionality in ReactOS, so I added a '#ifdef REACTOS' to the test to skip it.

      For the other one according to dll/win32/msafd/misc/stubs.c there are three associated unimplemented functions as follows:

      1) WSPAcceptEx
      2) WSPConnectEx
      3) WSPDisconnectEx

      So I have #ifndef'ed all three of these tests for now. This test is currently black-listed.
      In my testing, I have seen much variability in the number of tests done run-to-run.
      It is not obvious why we have this, but it is there for anyone to see.

      I plan to do another testbot run and then follow it by a PR soon.

      Attachments

        Issue Links

          Activity

            People

              DougLyons DougLyons
              DougLyons DougLyons
              Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: