Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10690

explorer systray icon issue & comctl32

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Fix Version/s: None
    • Component/s: Shell, Wine
    • Labels:
    • Environment:

      reactos trunk bootcd r70327
      VBox 4.3.34

      Description

      We still have issues displaying the systray-icon of
      -TightVNC 2.7.10
      -Abyss WebServer
      -uTorrent 3.4.7
      -BitTorrent 7.9.6
      -Pidgin 2.10.12

      in explorer systray. see react-r70327-systray.webm

      Some months ago I created
      comctl32-fix-ros.patch
      which corrects the issue,
      see react-r70327-systray-withComCtl32Patch.webm
      but it is just a hackfix.

      It does so by changing implementation of ImageList_ReplaceIcon()
      for index > maxIndex to show the same behavior as for index == -1
      (add the image)

      I guess comctl32 is the right place to fix it, but I can not verify easily with XPs comctl32 in ros, as no icons are drawn then at all.

      I have been running the hackfix for several months without an issue. We should work on a proper solution for that issue.

        Attachments

        1. 0.4.8-dev-864-g804472f.png
          29 kB
          reactosfanboy
        2. comctl32-fix-ros.patch
          0.6 kB
          reactosfanboy
        3. r75390_vs__comctl_2k3_5_82_3790_3959.png
          18 kB
          reactosfanboy
        4. react-r70327-systray.webm
          2.12 MB
          reactosfanboy
        5. react-r70327-systray-withComCtl32Patch.webm
          1.98 MB
          reactosfanboy
        6. systray-r65495-explorerOld-workingOK.png
          15 kB
          reactosfanboy
        7. systray-r65496-explorerNew-workingOK.png
          21 kB
          reactosfanboy
        8. systray-r68893-explorerNew-thisRevisionStartedDoubling(alsoOnXP).png
          25 kB
          reactosfanboy

          Issue Links

            Activity

              People

              • Assignee:
                reactosfanboy reactosfanboy
                Reporter:
                reactosfanboy reactosfanboy
              • Votes:
                4 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: