Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10962

[shell32]: Use ExpandEnvironmentStringsW in pick icon dialog

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: 0.4.3
    • Component/s: Shell
    • Labels:

      Description

      Currently, the Choose Icon dialog uses PathUnExpandEnvStringsW. The path textbox then has %systemroot% in the string while XP expands it. I've also found that using this patch now means that one can select an icon from shell32 for a shortcut and it actually works instead of being a white square (don't quote me on that ).

        Attachments

        1. dialogs.cpp.patch
          1 kB
        2. patch.png
          patch.png
          37 kB
        3. server_2003.PNG
          server_2003.PNG
          89 kB

          Issue Links

            Activity

              People

              • Assignee:
                Smiley Giannis Adamopoulos
                Reporter:
                Pi_User5 Pi_User5
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: