Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10962

[shell32]: Use ExpandEnvironmentStringsW in pick icon dialog

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.3
    • Shell

    Description

      Currently, the Choose Icon dialog uses PathUnExpandEnvStringsW. The path textbox then has %systemroot% in the string while XP expands it. I've also found that using this patch now means that one can select an icon from shell32 for a shortcut and it actually works instead of being a white square (don't quote me on that ).

      Attachments

        1. dialogs.cpp.patch
          1 kB
        2. patch.png
          patch.png
          37 kB
        3. server_2003.PNG
          server_2003.PNG
          89 kB

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. CORE-10972 [shell32] Choose Icon dialog does not work

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-9871 Change icon to shortcut show a white rectangle as result

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              Smiley Giannis Adamopoulos
              Pi_User5 Pi_User5
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: