Core ReactOS
  1. Core ReactOS
  2. CORE-11915

[WIN32SS/USER32] Pseudo-Regressions of r72495 (here: RegEdit via stress.bat crashes)

    Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Fix Version/s: 0.4.4
    • Component/s: None
    • Labels:
    • Guilty Revision:
      72,495

      Description

      When we run stress.bat we see that we get a

      err:(win32ss/user/user32/windows/message.c:1506) Exception when calling unicode WndProc 0040AD8A Msg 6 pti B1D23B88 Wndpti B1D23B88
      

      with each Regedit-iteration.
      This was also wrong with r72494, see log72494, but we had no user visible symptom back then.
      With r72495 we removed that exception handler and therefore we do not longer hide the underlying issue.
      As a result each iteration now gives a crash-box, see log72495

      Preferably we should fix the underlying issue asap.
      If we can not manage this until 0.4.3 release, we should consider temporarilly reverting r72495 as a release-hack.

      I consider this a 0.4.3 blocker.

        Issue Links

          Activity

          Hide
          Mark Jansen
          added a comment -

          g_pChildWnd gets zeroed in WM_DESTROY, which is not guaranteed to be the last message sent.
          I will go ahead and commit this fix soon (tm).

          Show
          Mark Jansen
          added a comment - g_pChildWnd gets zeroed in WM_DESTROY , which is not guaranteed to be the last message sent. I will go ahead and commit this fix soon (tm).
          Hide
          Mark Jansen
          added a comment -

          I have not tested this again, but I assume the recent fixes for cmd have made this harder to reproduce?

          Show
          Mark Jansen
          added a comment - I have not tested this again, but I assume the recent fixes for cmd have made this harder to reproduce?
          Hide
          reactosfanboy
          added a comment -

          no, I retested immediately after our cmd-fix as I did expect the same, but interestingly it happens the same as before: about one crashbox per iteration.

          Show
          reactosfanboy
          added a comment - no, I retested immediately after our cmd-fix as I did expect the same, but interestingly it happens the same as before: about one crashbox per iteration.
          Hide
          Mark Jansen
          added a comment -

          Thanks for re-testing, I'll try to get this patch in tonight

          Show
          Mark Jansen
          added a comment - Thanks for re-testing, I'll try to get this patch in tonight
          Hide
          reactosfanboy
          added a comment -

          r73378 is now able to survive stress.bat cycles. Still I see some regedit crashes now and then during normal user interaction with the program (that started with r72495) but I don't know a reliable way to trigger them yet (often the search is involved). I consider this ticket to be adressed and will open a new ticket as soon as I can get one of these other regedit-crashes.
          Still I would prefer to leave this ticket open until it's children are closed - I want to continue to abuse it as anchor task for 72495-Pseudos

          Show
          reactosfanboy
          added a comment - r73378 is now able to survive stress.bat cycles. Still I see some regedit crashes now and then during normal user interaction with the program (that started with r72495) but I don't know a reliable way to trigger them yet (often the search is involved). I consider this ticket to be adressed and will open a new ticket as soon as I can get one of these other regedit-crashes. Still I would prefer to leave this ticket open until it's children are closed - I want to continue to abuse it as anchor task for 72495-Pseudos

            People

            • Assignee:
              Bug Zilla
              Reporter:
              reactosfanboy
            • Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated: