Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14005

Lower/Mixed/Upper case of system root directory, "ReactOS", for both BootCD/LiveCD

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Fix
    • Minor
    • None
    • None
    • None

    Description

      It seems Windows uses upper case for a few directories (and files).

      For example:

      Windows XP: WINDOWS RECYCLER NTDETECT.COM
      ROS BootCD: ReactOS RECYCLED
      ROS LiveCD: reactos
      

      In this issue, I am interested in system root directory only.
      Which case should we use? REACTOS, ReactOS or reactos?

      0.4.8-dev-97-g9429831
      BootCD itself has reactos, but, once installed, HDD has ReactOS.
      LiveCD itself has reactos too, which, once booted, is used as is.

      LiveCD case:

      $ ninja -v livecd
      [3/3] cd .../output-MinGW-i386/reactos/boot && .../mkisofs ... .../livecd.lst ...
      

      sdk/cmake/CMakeMacros.cmake

       165 macro(dir_to_num dir var)
       166     if(${dir} STREQUAL reactos/system32)
       167         set(${var} 1)
       ...
       
       277 function(add_cd_file)
       ...
      

      add_cd_file grep

      add_cd_file(TARGET atactl DESTINATION reactos/system32 FOR all)
      ...
      

      Would there be a simple solution to rename reactos to ReactOS at build time?
      Or would we have to update all add_cd_file() calls in source?

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Serge Gautherie Serge Gautherie
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: