Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14350

RAPPS Certificate pinning is broken

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.8
    • Component/s: None
    • Labels:
      None

      Description

      Rapps Certificate 'pinning' is completely broken:

      1. We open a NEW connection to request the certificate
      2. The certificate is checked for ISSUER and SUBJECT INFO
      3. If a field we want to check is not present, we do not care
      4. Wrong types are used, cast to whatever we need

      Each of these points on their own is already enough to make it completely not work,
      and the second point is why we cannot download files with LE certificates.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                learn_more Mark Jansen
                Reporter:
                learn_more Mark Jansen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: