Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14622

[comctl32] Regression Background Colour is displayed grey but should be white (where no text is) in setup wizard of Antivir

    XMLWordPrintable

Details

    Description

      0.4.9-dev-787-g7673837 gcc dbg
      "Avira Antivir Personal 6.35.00.243" from http://www.oldversion.com/windows/avira-antivir-6-35-00-243

      We have a regression in comctl32 that was introduced with SVN74136 comctl32/propsheet hbelusca

      ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png
      Most of that screen should be white.

      It has to look like in xp.png

      backgroundcolor-regressiontest.txt points to 2 interesting commits in comctl32, both from hbelusca:
      -SVN74136 which broke it
      -0.4.8-dev-56-g11049bd which already fixed part of it again, see CORE-13929

      Please watch these videos carefully:
      r73441-ok.webm
      r74136.webm most broken
      0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm

      The videos show multiple issues, some of them can be fixed by enforcing a repaint (moving on and off screen). For example the wrong background in the header sections and the initially not painted pictures in the header section. Those issues are not part of this ticket.

      The ticket is solely about the wrong background colour that is grey and should be white, and this issue can not be fixed by an enforced repaint

      Attachments

        1. xp.png
          xp.png
          75 kB
        2. ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png
          ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png
          32 kB
        3. test_propsheet.zip
          1.53 MB
        4. r74136.webm
          3.41 MB
        5. r73441-ok.webm
          2.86 MB
        6. propsheet_Pics.7z
          6.44 MB
        7. propsheet_c.patch
          0.6 kB
        8. propsheet_c.patch
          1.0 kB
        9. propsheet_c.patch
          1 kB
        10. propsheet_c.patch
          1 kB
        11. min_propsheet_c.patch
          0.5 kB
        12. backgroundcolor-regressiontest.txt
          2 kB
        13. avira_install_hacks_ros.png
          avira_install_hacks_ros.png
          80 kB
        14. Avira_good03.png
          Avira_good03.png
          175 kB
        15. Avira_Good.png
          Avira_Good.png
          79 kB
        16. 0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm
          4.16 MB

        Issue Links

          Activity

            People

              reactosfanboy reactosfanboy
              reactosfanboy reactosfanboy
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: