Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-15303

Regression Firefox 28 does not longer show the checkmarks in the menubar

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.12
    • Component/s: Win32SS
    • Labels:
    • Module:
    • Guilty Commit:
      0.4.10-dev-466-35f62fc5ba0b69e7335ff41400cb3b45660f4557

      Description

      0.4.10-RC-30-g51a70dc gcc dbg is affected
      Firefox 28 from rapps
      does not longer show the checkmarks in menubar (e.g. for bookmark bar).
      0.4.10-RC-30-g51a70dc_FF28_noCheckmarkInMenubar_forBookmarksBar.png

      I verified that it's a regression, 0.4.10-dev-357-g2158f31 did still show the checkmarks!
      0.4.10-dev-357-g2158f31__wasStillOk.png
      (and we did not ship this regression until now, it happened during 0.4.10deving)
      We must hunt the guilty rev!
      0.4.10-RC-30-g51a70dc.log is no help.

      For comparison:
      2k3-correct.png 2k3 and XPSP3 do both look fine.

        Attachments

        1. 0.4.10-RC-30-g51a70dc__FF28__noCheckmarkInMenubar_forBookmarksBar.png
          0.4.10-RC-30-g51a70dc__FF28__noCheckmarkInMenubar_forBookmarksBar.png
          64 kB
        2. 0.4.10-dev-357-g2158f31__wasStillOk.png
          0.4.10-dev-357-g2158f31__wasStillOk.png
          55 kB
        3. 0.4.10-RC-30-g51a70dc.log
          35 kB
        4. CORE-15303__RegressionTest.txt
          0.4 kB
        5. bug-confirmed.png
          bug-confirmed.png
          48 kB
        6. 2k3-correct.png
          2k3-correct.png
          29 kB
        7. firefox-api-monitor.png
          firefox-api-monitor.png
          80 kB
        8. marlett-13-confirmed.png
          marlett-13-confirmed.png
          38 kB
        9. strange-phenomenon.png
          strange-phenomenon.png
          21 kB
        10. freetype_c_ff28_Fix.patch
          0.6 kB
        11. VirtualBox_ReactOS_03_12_2018_11_47_11.png
          VirtualBox_ReactOS_03_12_2018_11_47_11.png
          47 kB
        12. font-size.patch
          0.6 kB
        13. 0.4.11-RC-29-g97ab52a__affected.png
          0.4.11-RC-29-g97ab52a__affected.png
          49 kB
        14. 0.4.11-RC-29-g97ab52a__xpMarlett.png
          0.4.11-RC-29-g97ab52a__xpMarlett.png
          60 kB
        15. ff28_menu_check_fix_draw_c.patch
          0.5 kB
        16. patch_failed.png
          patch_failed.png
          97 kB
        17. IntRequestFontSize_Debug.txt
          5 kB
        18. Debug_Marlett.txt
          4 kB
        19. confirm-fixed-19fc941.png
          confirm-fixed-19fc941.png
          62 kB
        20. 0.4.12-RC-16-ge1ac9dc__ok.png
          0.4.12-RC-16-ge1ac9dc__ok.png
          49 kB

          Issue Links

            Activity

              People

              • Assignee:
                katayama_hirofumi_mz Katayama Hirofumi MZ
                Reporter:
                reactosfanboy reactosfanboy
              • Votes:
                3 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: