Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16068

Explorer crashes with invalid memory access

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.15
    • Shell

    Description

      Code

       

          /* If the user isn't resizing the tray window we need to make sure      the new size or position is valid. this is to prevent changes to the window without user interaction. */
       rcTray = m_TrayRects[m_Position];
       
      

      m_Position == -1!

       

      Backtrace:

       

      # Child-SP RetAddr Call Site
      00 fffff880`04dbe170 fffff800`004030d5 nt!KiDispatchException+0x252 [E:\amd64\reactos\ntoskrnl\ke\amd64\except.c @ 344] 
      01 fffff880`04dbe6c0 fffff800`0040446b nt!InternalDispatchException+0xef
      02 fffff880`04dbe8a0 00000001`40021517 nt!KiPageFault+0x12d
      03 00000000`0012e7c0 00000001`40025ff6 explorer!CTrayWindow::ChangingWinPos+0x297 [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 1369] 
      04 00000000`0012e820 00000001`400274c2 explorer!CTrayWindow::OnWindowPosChanging+0x26 [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 2462] 
      05 00000000`0012e850 00000001`4000fa8c explorer!CTrayWindow::ProcessWindowMessage+0x7c2 [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 3111] 
      06 00000000`0012e8e0 000007ff`b2580a39 explorer!ATL::CWindowImplBaseT<CToolbar<InternalIconData>,ATL::CWinTraits<1442840576,0> >::WindowProc+0xfc [E:\amd64\reactos\sdk\lib\atl\atlwin.h @ 1564] 
      07 00000000`0012e990 000007ff`b2585382 user32!IntCallWindowProcW+0x719 [E:\amd64\reactos\win32ss\user\user32\windows\message.c @ 1546] 
      08 00000000`0012eaa0 000007ff`b7518242 user32!User32CallWindowProcFromKernel+0x4c2 [E:\amd64\reactos\win32ss\user\user32\windows\message.c @ 3004] 
      09 00000000`0012ebc0 000007ff`b2596e8f ntdll!KiUserCallbackDispatcher+0x2a
      0a 00000000`0012ec88 00000001`4000e2cf user32!NtUserSetWindowPos+0xa
      0b 00000000`0012ec90 00000001`40025f59 explorer!ATL::CWindow::SetWindowPos+0x4f [E:\amd64\reactos\sdk\lib\atl\atlwin.h @ 1224] 
      0c 00000000`0012ece0 00000001`40026e2e explorer!CTrayWindow::OnThemeChanged+0xc9 [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 2301] 
      0d 00000000`0012ed30 00000001`4000fa8c explorer!CTrayWindow::ProcessWindowMessage+0x12e [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 3092] 
      0e 00000000`0012edc0 000007ff`b2580a39 explorer!ATL::CWindowImplBaseT<CToolbar<InternalIconData>,ATL::CWinTraits<1442840576,0> >::WindowProc+0xfc [E:\amd64\reactos\sdk\lib\atl\atlwin.h @ 1564] 
      0f 00000000`0012ee70 000007ff`b257f828 user32!IntCallWindowProcW+0x719 [E:\amd64\reactos\win32ss\user\user32\windows\message.c @ 1546] 
      10 00000000`0012ef80 000007ff`b2584a58 user32!IntCallMessageProc+0x2d8 [E:\amd64\reactos\win32ss\user\user32\windows\message.c @ 1797] 
      11 00000000`0012f000 000007ff`89516275 user32!SendMessageW+0x178 [E:\amd64\reactos\win32ss\user\user32\windows\message.c @ 2402] 
      12 00000000`0012f0e0 000007ff`89516228 uxtheme!UXTHEME_send_theme_changed+0x25 [E:\amd64\reactos\dll\win32\uxtheme\system.c @ 64] 
      13 00000000`0012f110 000007ff`89514ddc uxtheme!UXTHEME_broadcast_theme_changed+0x38 [E:\amd64\reactos\dll\win32\uxtheme\system.c @ 77] 
      14 00000000`0012f140 00000001`40024726 uxtheme!SetWindowTheme+0x13c [E:\amd64\reactos\dll\win32\uxtheme\system.c @ 888] 
      15 00000000`0012f1a0 00000001`40026ffe explorer!CTrayWindow::OnCreate+0x76 [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 2214] 
      16 00000000`0012f230 00000001`4000fa8c explorer!CTrayWindow::ProcessWindowMessage+0x2fe [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 3097] 
      17 00000000`0012f2c0 000007ff`b2580a39 explorer!ATL::CWindowImplBaseT<CToolbar<InternalIconData>,ATL::CWinTraits<1442840576,0> >::WindowProc+0xfc [E:\amd64\reactos\sdk\lib\atl\atlwin.h @ 1564] 
      18 00000000`0012f370 000007ff`b2585382 user32!IntCallWindowProcW+0x719 [E:\amd64\reactos\win32ss\user\user32\windows\message.c @ 1546] 
      19 00000000`0012f480 000007ff`b7518242 user32!User32CallWindowProcFromKernel+0x4c2 [E:\amd64\reactos\win32ss\user\user32\windows\message.c @ 3004] 
      1a 00000000`0012f5a0 000007ff`b25965ec ntdll!KiUserCallbackDispatcher+0x2a
      1b 00000000`0012f698 000007ff`b258f9a0 user32!NtUserCreateWindowEx+0xa
      1c 00000000`0012f6a0 000007ff`b258d36e user32!User32CreateWindowEx+0x590 [E:\amd64\reactos\win32ss\user\user32\windows\window.c @ 289] 
      1d 00000000`0012f8a0 00000001`4000a4b1 user32!CreateWindowExW+0x61e [E:\amd64\reactos\win32ss\user\user32\windows\window.c @ 575] 
      1e 00000000`0012f9b0 00000001`400218ce explorer!ATL::CWindowImplBaseT<ATL::CWindow,ATL::CWinTraits<1442840576,0> >::Create+0x181 [E:\amd64\reactos\sdk\lib\atl\atlwin.h @ 1611] 
      1f 00000000`0012fa30 00000001`4002615c explorer!ATL::CWindowImpl<CTrayWindow,ATL::CWindow,ATL::CWinTraits<1442840576,0> >::Create+0x10e [E:\amd64\reactos\sdk\lib\atl\atlwin.h @ 1651] 
      20 00000000`0012fab0 00000001`40021a7a explorer!CTrayWindow::Open+0x14c [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 2069] 
      21 00000000`0012fb50 00000001`40002241 explorer!CreateTrayWindow+0xaa [E:\amd64\reactos\base\shell\explorer\traywnd.cpp @ 3399] 
      22 00000000`0012fbc0 00000001`4000254b explorer!StartWithDesktop+0xe1 [E:\amd64\reactos\base\shell\explorer\explorer.cpp @ 155] 
      23 00000000`0012fe10 00000001`4002c69e explorer!wWinMain+0xeb [E:\amd64\reactos\base\shell\explorer\explorer.cpp @ 224] 
      24 00000000`0012fe60 00000001`4002c27e explorer!wmain+0x2e [E:\amd64\reactos\sdk\lib\crt\startup\crt0_w.c @ 26] 
      25 00000000`0012fe90 00000001`4002c500 explorer!__tmainCRTStartup+0x29e [E:\amd64\reactos\sdk\lib\crt\startup\crtexe.c @ 312] 
      26 00000000`0012ff60 000007ff`b6514c2a explorer!wWinMainCRTStartup+0x20 [E:\amd64\reactos\sdk\lib\crt\startup\crtexe.c @ 172] 
      27 00000000`0012ffa0 00000000`00000000 kernel32!BaseProcessStartup+0x2a [E:\amd64\reactos\dll\win32\kernel32\client\proc.c @ 463]
       
      

       

      Attachments

        Activity

          People

            ThePhysicist Timo Kreuzer
            ThePhysicist Timo Kreuzer
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: