Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16622

Regression, Our print dialog throws an exception (which leads to wrong painting), triggerable via Kompozer from rapps

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.13
    • Component/s: None
    • Labels:

      Description

      I think the glitch in this dialog is in ros source, print dlg resources just.

      Reproduction steps

      • install ros with german localization
      • The shortest way I know is to download "Kompozer 0.7.10" from rapps, unzip the zip
      • run its main app
      • select "file/print" from menubar
      • (maybe we can reach that dlg even quicker via some other vector)

      Observed result
      The "help" button should not be there, it is erroneously placed within that english text (which the app Kompozer seems to "glue" into that dlg by itself). A first chance exception is thrown here.
      0.4.13-RC-38-g3803e58_print.png
      0.4.13-RC-38-g3803e58_print.log

      Expected result
      2k3sp2_ok.png for comparison reasons, the same dialog when app is run in 2k3sp2 (unfortunately this is the english 2k3sp2 and therefore the dlg looks a bit different). It does show the english text as well, but no such help button.
      win_xp_ger.png no help button, but also draws the english text

      0.4.13-RC-0-g07ad6e8_Pseudo_GoodPath.png did draw differently, Different to what I initially thought it does not draw better (as we know know, it did draw even worse, because it not eating up the exception yet and therefore does not show the english text, that in fact must be there)

        Attachments

        1. 0.4.13-dev-2-g88f899e-x86-gcc-lin-dbg_stillOk.png
          29 kB
          reactosfanboy
        2. 0.4.13-RC-0-g07ad6e8_Pseudo_GoodPath.png
          28 kB
          reactosfanboy
        3. 0.4.13-RC-0-g07ad6e8.iso_Pseudo_GoodPath.log
          73 kB
          reactosfanboy
        4. 0.4.13-RC-1-gbff758f_unhider.png
          31 kB
          reactosfanboy
        5. 0.4.13-RC-38-g3803e58_print.log
          85 kB
          reactosfanboy
        6. 0.4.13-RC-38-g3803e58_print.png
          38 kB
          reactosfanboy
        7. 0.4.14-dev-1035-g16baab2_PRPR2339_afterFirst4_09395d5.png
          30 kB
          reactosfanboy
        8. 0.4.14-dev-796-g10a4ecd_ok.png
          28 kB
          reactosfanboy
        9. 0413_RC_ok.png
          30 kB
          reactosfanboy
        10. 2k3sp2_ok.png
          39 kB
          reactosfanboy
        11. by_the_way_uninitialized_data_is_passed_into_the_combobox.png
          29 kB
          reactosfanboy
        12. CORE-16622_printing_boost_ansi_for0_4_13RC.patch
          65 kB
          reactosfanboy
        13. does_not_work_anymore.png
          30 kB
          reactosfanboy
        14. EnumPrinters.png
          65 kB
          DougLyons
        15. EnumPrinters1.png
          102 kB
          DougLyons
        16. EnumPrinters2.png
          71 kB
          DougLyons
        17. EnumPrintersA_printers_c.patch
          2 kB
          DougLyons
        18. enumprt.c
          4 kB
          DougLyons
        19. enumprt.exe
          43 kB
          DougLyons
        20. Kompozer_good.png
          53 kB
          DougLyons
        21. my_first_patch_interesting_result.png
          29 kB
          reactosfanboy
        22. my_first_patch.diff
          0.8 kB
          reactosfanboy
        23. perfect_also_for_german_also_on_RC.png
          29 kB
          reactosfanboy
        24. PR2339_afterFirst4_09395d5.patch
          35 kB
          reactosfanboy
        25. printdlg_c.patch
          1 kB
          DougLyons
        26. printers_c_3.patch
          30 kB
          DougLyons
        27. printers_getprintera.patch
          17 kB
          DougLyons
        28. printing.patch
          15 kB
          jimtabor
        29. r73441_prevented.png
          42 kB
          reactosfanboy
        30. r74432_ok.png
          38 kB
          reactosfanboy
        31. r74433_bad.png
          30 kB
          reactosfanboy
        32. VAD_Fix_printers_c.patch
          0.8 kB
          DougLyons
        33. win_xp_ger.png
          17 kB
          DarkShadow44

          Issue Links

            Activity

              People

              • Assignee:
                reactosfanboy reactosfanboy
                Reporter:
                reactosfanboy reactosfanboy
              • Votes:
                2 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: