Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16693

!Reproducible! heap assert in msiexec, when installing Tortoise Git 1.8.16.0

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.15
    • Wine
    • None

    Description

      Reproduction steps

      • run msi setup of "Tortoise Git 1.8.16.0" from rapps
      • in the dlg where you can select/deselect components, now comes the crucial step
      • select some component in that dlg, the blue selection rectangle must be over a component or the bug won't happen later, see important.png
      • now and not earlier click "browse" for installation target dir
      • the browsefor destination dialog will be affected by "_BrowseProperty"-issue CORE-15315 (you are on the perfect path then)
      • ignore that fact and just click the button to browse to parent directory
      • It will give a heap assertion, it happens reproducibly for me

      I took a backtrace with break-on-first-chance enabled in the end of the log
      0.4.13-RC-42-g05225f1_msiexec_heapassert.log
      0.4.13-RC-42-g05225f1_msiexec_heapassert.png

      Here is an exact reproduction video that you can and must follow click by click
      click-by-click-repro.webm

      Attachments

        1. 0.4.13-RC-42-g05225f1_msiexec_heapassert.log
          1.41 MB
        2. 0.4.13-RC-42-g05225f1_msiexec_heapassert.png
          0.4.13-RC-42-g05225f1_msiexec_heapassert.png
          63 kB
        3. 15-7248_TortoiseGit-01.png
          15-7248_TortoiseGit-01.png
          121 kB
        4. click-by-click-repro.webm
          482 kB
        5. image-2022-11-04-08-31-35-253.png
          image-2022-11-04-08-31-35-253.png
          26 kB
        6. image-2023-12-17-15-23-37-299.png
          image-2023-12-17-15-23-37-299.png
          65 kB
        7. important.png
          important.png
          52 kB
        8. msi_dialog_c_11.patch
          0.6 kB
        9. ReactOS.log
          109 kB

        Issue Links

          Activity

            People

              DougLyons DougLyons
              reactosfanboy reactosfanboy
              Votes:
              4 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: