Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16735

Scrollbars theming regression

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: 0.4.14
    • Component/s: Win32SS
    • Labels:
    • Environment:

      VirtualBox 5.1.38, clean installation.

    • Module:
    • Guilty Commit:
      0.4.14-dev-1134-g00adb1a3f967ac7f5cd56b4c39df72a7b3814603

      Description

      Reproducing steps:

      1. Enable any theme in ReactOS besides Classic (e. g. Lunar).
      2. Open My Computer.
      3. Go to C:\ReactOS or C:\ReactOS\system32 directory.
      4. Scroll the folder up/down via mouse wheel or via left mouse button.
      5. Look at the scrollbars.

      0.4.14-dev-1133-g6831468ccfdedb4eb8c7cc88ac2a01f35dbfc16b - they draw correctly. Theming doesn't disappear.
      0.4.14-dev-1134-g00adb1a3f967ac7f5cd56b4c39df72a7b3814603 - they draw incorrectly. Theming disappears very often. When scrolling the folder via mouse wheel, it's completely missing on the scrollbar itself whole time, but not on the scrollbar arrows. If to scroll via left mouse button, theming disappears intermittently, when moving the scrollbar itself. Up and Down arrows almost are not affected.

      It can be reproduced by any other way, via any program, which uses themed scrollbars (builtin or native). E. g., I tested Task Manager, and there are exactly the same sympthoms with the scrollbars.

      The guilty commit seems to be improvements in the scollbars drawing code in our Win32SS. So I guess this is a source of actual problem, if not uxtheme.

      Demonstration videos and debug.log are also attached. Btw, I don't see any debug spam in the log from win32ss/user/ntuser/scrollbar.c.

        Attachments

        1. 0.4.14-dev-1133-g6831468.webm
          1.37 MB
        2. 0.4.14-dev-1134-g00adb1a.webm
          3.12 MB
        3. debug.log
          38 kB
        4. new_debug_2.log
          118 kB
        5. new_debug_3.log
          146 kB
        6. new_debug_4.log
          181 kB
        7. new_debug.log
          63 kB
        8. new_scroll.patch
          3 kB
        9. ReactOS-2020-10-build1112-Luna_from_RAPPS.webm
          997 kB
        10. sb.patch
          0.6 kB
        11. scrollbar_hack_fix.patch
          5 kB
        12. scrollbar_hack_fix1.patch
          5 kB
        13. scrollbar_hack_fix2.patch
          5 kB
        14. scrollbar_hack_fix3.patch
          4 kB

          Activity

            People

            • Assignee:
              bug zilla Bug Zilla
              Reporter:
              Oleg Dubinskij Oleg Dubinskiy
            • Votes:
              6 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated: