Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16735

Scrollbars theming regression, sometimes a themed scrollbar is not drawn until you hover it with the mouse

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.14, 0.4.15
    • Component/s: Win32SS
    • Labels:
    • Environment:

      VirtualBox 5.1.38, clean installation.

      Description

      Reproducing steps:

      1. Enable any theme in ReactOS besides Classic (e. g. Lunar).
      2. Open My Computer.
      3. Go to C:\ReactOS or C:\ReactOS\system32 directory.
      4. Scroll the folder up/down via mouse wheel or via left mouse button.
      5. Look at the scrollbars.

      0.4.14-dev-1133-g6831468ccfdedb4eb8c7cc88ac2a01f35dbfc16b - they draw correctly. Theming doesn't disappear.
      0.4.14-dev-1134-g00adb1a3f967ac7f5cd56b4c39df72a7b3814603 - they draw incorrectly. Theming disappears very often. When scrolling the folder via mouse wheel, it's completely missing on the scrollbar itself whole time, but not on the scrollbar arrows. If to scroll via left mouse button, theming disappears intermittently, when moving the scrollbar itself. Up and Down arrows almost are not affected.

      It can be reproduced by any other way, via any program, which uses themed scrollbars (builtin or native). E. g., I tested Task Manager, and there are exactly the same sympthoms with the scrollbars.

      The guilty commit seems to be improvements in the scollbars drawing code in our Win32SS. So I guess this is a source of actual problem, if not uxtheme.

      Demonstration videos and debug.log are also attached. Btw, I don't see any debug spam in the log from win32ss/user/ntuser/scrollbar.c.

      -----------
      Edit by reactosfanboy: I just realized, that we did not even have a video in here of any affected build, so I decided to attach a video that demonstrates on the last affected build, that
      the themed scrollbars are broken and sometimes not properly drawn (interacting with the vertical scrollbar breaks the horizontal one and the other way round). The other scrollbar is not properly painted unless it is hovered again with the mouse pointer
      0.4.15-dev-3085-g515e0cf_ThisVideoDemonstrates_CORE-16735_whatIsWrongWithThemes_ButHowItWorksFineWithClassic.webm
      but the video does also show that the unthemed scrollbars do work fine in that build

        Attachments

        1. WinXP theme enabled.png
          WinXP theme enabled.png
          19 kB
        2. WinProp_WithTheme.png
          WinProp_WithTheme.png
          67 kB
        3. WinProp_ThemeServiceStopped.png
          WinProp_ThemeServiceStopped.png
          65 kB
        4. WinProp_NoTheme.png
          WinProp_NoTheme.png
          69 kB
        5. W2K3SP2_ThemeActive1.png
          W2K3SP2_ThemeActive1.png
          132 kB
        6. VirtualBox_ReactOS4_11_09_2021_10_11_29.png
          VirtualBox_ReactOS4_11_09_2021_10_11_29.png
          64 kB
        7. VirtualBox_20210919-0.4.15-dev-3174-gdda9c39.png
          VirtualBox_20210919-0.4.15-dev-3174-gdda9c39.png
          79 kB
        8. scrollbars-fixed.webm
          8.08 MB
        9. scrollbar_hack_fix3.patch
          4 kB
        10. scrollbar_hack_fix2.patch
          5 kB
        11. scrollbar_hack_fix1.patch
          5 kB
        12. scrollbar_hack_fix.patch
          5 kB
        13. scrollbar_c_12.patch
          6 kB
        14. scrollbar_c_07.patch
          4 kB
        15. scrollbar_c_04.patch
          3 kB
        16. scrollbar_c_03.patch
          3 kB
        17. scrollbar_c_02.patch
          3 kB
        18. scrollbar_c_01.patch
          3 kB
        19. sb.patch
          0.6 kB
        20. RosBE_Scrollbar_Fix_Time_Optimized.png
          RosBE_Scrollbar_Fix_Time_Optimized.png
          81 kB
        21. RosBE_Scrollbar_Fix_Compare.png
          RosBE_Scrollbar_Fix_Compare.png
          138 kB
        22. recommendedTest.png
          recommendedTest.png
          60 kB
        23. ReactOS-2020-10-build1112-Luna_from_RAPPS.webm
          997 kB
        24. ReactOS_ThemeActive.png
          ReactOS_ThemeActive.png
          95 kB
        25. patched.webm
          1.82 MB
        26. new_scroll.patch
          3 kB
        27. new_debug.log
          63 kB
        28. new_debug_4.log
          181 kB
        29. new_debug_3.log
          146 kB
        30. new_debug_2.log
          118 kB
        31. GUI1.exe
          9 kB
        32. GUI.cpp
          4 kB
        33. debug.log
          38 kB
        34. Debug_20210919-0.4.15-dev-3174-gdda9c39.log
          32 kB
        35. Debug_20210910-0.4.15-dev-3127-g183566e.log
          31 kB
        36. Classic theme enabled.png
          Classic theme enabled.png
          17 kB
        37. 0.4.15-dev-3085-g515e0cf_ThisVideoDemonstrates_CORE-16735_whatIsWrongWithThemes_ButHowItWorksFineWithClassic.webm
          2.91 MB
        38. 0.4.14-dev-1134-g00adb1a.webm
          3.12 MB
        39. 0.4.14-dev-1133-g6831468.webm
          1.37 MB

          Issue Links

            Activity

              People

              • Assignee:
                DougLyons DougLyons
                Reporter:
                Oleg Dubinskij Oleg Dubinskiy
              • Votes:
                7 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: