Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16903

[NETSHELL] RC Overhaul all languages

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.14
    • Component/s: Shell
    • Labels:
      None

      Description

      This task harmonizes 2dlgs RCs for all languages in netshell
      IDD_LAN_NETSTATUS & IDD_LAN_NETSTATUSADVANCED

      Reason for the change:

      • dlgs sizes did differ (between langs and also within same lang)
      • groupboxes sizes did differ (between langs and also within same lang)
      • tabbing through both dlgs looked poorly therefore in almost all langs (margin and groupbox jumping)
      • in some languages we had truncation
      • in some languages we had unintended scaling for the icon
      • after the change all controls and dlgs have the exact same size for all languages, I managed to achieve the common detominator for everything that looks good in all languages and guarantees to not introduce any truncation

      The only control that is not harmonized perfectly regarding its position and will continue the need to be tweaked for each language individually even after this commit is the icons horizontal position. I took great care about that, but can not guarantee, that it's really perfect for each and every language, so it may make sense to double-check that afterwards

      Here are some before and after of the patch
      videos for the most important langs:
      en-US-0before.webm -> en-US-1after.webm
      fr-FR-0before.webm -> fr-FR-1after.webm
      de-DE-0before.webm -> de-DE-1after.webm
      ru-RU-0before.webm -> ru-RU-1after.webm

      after pics at least for some other langs:
      es-ES.png
      hu-HU.png
      it-IT.png
      jp-JP.png (sorry had the fonts not installed)
      no-NO.png
      pl-PL.png
      ro-RO.png
      zh-TW.png (sorry had the fonts not installed)
      Please let me know if the icon is not perfectly centered for your (exotic) language after this commit!

        Attachments

        1. de-DE-0before.webm
          422 kB
        2. de-DE-1after.webm
          206 kB
        3. en-US-0before.webm
          369 kB
        4. en-US-1after.webm
          248 kB
        5. es-ES.png
          es-ES.png
          15 kB
        6. fr-FR-0before.webm
          367 kB
        7. fr-FR-1after.webm
          471 kB
        8. hu-HU.png
          hu-HU.png
          15 kB
        9. it-IT.png
          it-IT.png
          15 kB
        10. jp-JP.png
          jp-JP.png
          17 kB
        11. no-NO.png
          no-NO.png
          15 kB
        12. pl-PL.png
          pl-PL.png
          15 kB
        13. ro-RO.png
          ro-RO.png
          15 kB
        14. ru-RU-0before.webm
          363 kB
        15. ru-RU-1after.webm
          305 kB
        16. zh-TW.png
          zh-TW.png
          17 kB

          Activity

            People

            • Assignee:
              reactosfanboy reactosfanboy
              Reporter:
              reactosfanboy reactosfanboy
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: