Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17005

Broken toolbar icons in MSVC builds

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.15
    • Win32SS
    • None

    Description

      Steps to reproduce:

      • Start Live CD
      • Run Wordpad from the Start menu
      • Expected: Toolbar icons are looking correct
      • Observed: Toolbar icons are shifted by a few pixels to the right

      Also "Browse for file" dialog is affected, you can open it with Ctrl+O from Wordpad.

      Only MSVC builds are affected, earliest known is 0.4.15-dev-142-gc276681.

      Attachments

        1. 0.4.15-dev-5224-g4572aad-x86-msvc.png
          42 kB
          Stas'M
        2. 0.4.15-dev-5224-g4572aad-x86-msvc.txt
          48 kB
          Stas'M
        3. comctl32_msvc_vs_gcc_bitmap_resources.png
          93 kB
          DougLyons
        4. comctl32_msvc_vs_gcc_risoh_editor.png
          151 kB
          DougLyons
        5. comctl32_res_compares.png
          87 kB
          DougLyons
        6. comctl32-msvc3.dll
          1.20 MB
          DougLyons
        7. cursoricon_toolbar_MSVC_vs_GCC.patch
          1 kB
          DougLyons
        8. image-2023-10-29-16-31-57-948.png
          20 kB
          KRosUser
        9. image-2024-04-28-12-14-13-060.png
          22 kB
          KRosUser
        10. image-2024-04-28-12-14-58-296.png
          30 kB
          KRosUser
        11. PR-6755.patch
          25 kB
          DougLyons
        12. PR-6755-01.patch
          25 kB
          DougLyons
        13. PR-6755-03.patch
          23 kB
          DougLyons
        14. PR-6755-04.patch
          19 kB
          DougLyons
        15. Resource_Hacker_Replace_Bitmap.png
          103 kB
          DougLyons
        16. Resource_Hacker_Save_Bitmap_Group_to_RES.png
          97 kB
          DougLyons
        17. Sans titre.png
          32 kB
          Kyle_Katarn
        18. wordpad-msvc-comctl32-dl-gcc1.png
          94 kB
          DougLyons

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. CORE-18157 [x64] Open as... dialog have icons a pixel to right.

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-11180 Difference GCC & MSVC build - mouse pointer/cursor shadow

          • Major - Major loss of function.
          • Reopened

          Activity

            People

              DougLyons DougLyons
              Kyle_Katarn Kyle_Katarn
              Votes:
              4 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: