Details
-
Bug
-
Resolution: Fixed
-
Major
-
None
-
Reproduced on AppVeyor and GitHub.
-
0.4.15-dev-1245-g5c7ce44 https://git.reactos.org/?p=reactos.git;a=commit;h=5c7ce4475e246560d1622b8cc60dc603e3955f66
Description
Affected: VS14 2015 (as in using Toolset v140). (msvc, msvc-amd64, msbuild, vssolution.)
Unaffected: VS15 2017 (v141), VS16 2019 (v141/v142).
–
Example:
C:\reactos-cov\win32ss\user\ntuser\timer.c(595): error C2983: 'InitTimerImpl': all declarations must have an identical __declspec(code_seg(...))
|
c:\reactos-cov\win32ss\user/ntuser/timer.h(35): note: see declaration of 'InitTimerImpl'
|
–
0.4.15-dev-1243-gba44701: Still builds fine.
0.4.15-dev-1244-g658f742: Does not compile.
0.4.15-dev-1245-g5c7ce44: Regressed. Cc extravert34.
–
Potential options:
- Stop bothering, so explicitly drop VS2015 support.
- Don't really care, so simply demote C2983 error to a warning. (If that is possible.)
- Actually fix these errors, so restoring/adding identical declarations.
- ...
Attachments
Issue Links
- blocks
-
CORE-7538 Make critical MSVC warnings into errors
- Open
- relates to
-
CORE-15991 [VSSolution] Loads of "error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier"
- Resolved