Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17545

Fix clang-12 warnings

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The build log from clang-12 is attached.
      For looking through all the warnings, search for pattern "[-W"
      The most interesting ones are: -Wcast-calling-convention, -Wuninitialized, -Wsometimes-uninitialized, -Wsizeof-array-div

      NOTE: some warnings were disabled for clang-cl, check cmakefiles

      After fixing one class of warnings, it makes sense to convert it to an error. Something like this should be put into gcc.cmake and tested on a CI:

      if(CMAKE_C_COMPILER_ID STREQUAL "Clang")
          add_compile_options("$<$<COMPILE_LANGUAGE:C,CXX>:-Werror=cast-calling-convention>")
      endif()
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                extravert34 extravert34
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: