Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17545

Fix clang-12 warnings

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The build log from clang-12 is attached.
      For looking through all the warnings, search for pattern "[-W"
      The most interesting ones are: -Wcast-calling-convention, -Wuninitialized, -Wsometimes-uninitialized, -Wsizeof-array-div

      NOTE: some warnings were disabled for clang-cl, check cmakefiles

      After fixing one class of warnings, it makes sense to convert it to an error. Something like this should be put into gcc.cmake and tested on a CI:

      if(CMAKE_C_COMPILER_ID STREQUAL "Clang")
      		 
          add_compile_options("$<$<COMPILE_LANGUAGE:C,CXX>:-Werror=cast-calling-convention>")
      		 
      endif()

        Attachments

          Issue Links

          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. CORE-17794 Huge number of warnings when compiling with Clang

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Task - A task that needs to be done. CORE-7538 Make critical MSVC warnings into errors

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. CORE-14306 (GitHub Actions) clang-cl 10 reports some warnings: review/fix them

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. CORE-17547 [GitHub] Clang-Cl 12.0.0: 'error: function declaration cannot have variably modified type'

          • Major - Major loss of function.
          • Resolved

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                extravert34 extravert34
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: