Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18047

Trying to extract a folder or file from a zip fails with "Got garbage pidl"

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • Shell
    • None

    Description

      Open an arbitrary zip file and try to extract contents from it via either

      • dragging it out to C:\ or
      • Ctrl+C and Ctrl+V it out to C:\

      Both will fail and we do log

      err:(/dll/win32/shell32/droptargets/CFSDropTarget.cpp:43) Got garbage pidl
      		 
      err:(/dll/win32/shell32/droptargets/CFSDropTarget.cpp:98) SHFileOperationW failed with 0x5

      It fails like this for all 3 builds I tested so far:
      0.4.13-release-58-gba0b031 (which did not receive yet the fix for CORE-16908)
      0.4.14-release-10-g1b0b852 (which did receive the fix for CORE-16908 already)
      recent master head 0.4.15-dev-3380-gab7b004.
      0.4.15-dev-3380-gab7b004_affected.webm
      0.4.15-dev-3380-gab7b004_affected.log

      I am not sure whether it ever worked since the zipfldr extension was introduced back during 0.4.9-dev'ing. But I was a bit surprised to see that 08/15-operation to still fail after that long time we do have that extension.

      Sidenote: ExtractAll from context menu of a zip uncompresses it fine.

      I used the following file for testing apitest.zip, but I do suspect each and every zip would trigger that bug.

      I guess the bug is either in module zipfldr or module shell32.

      Attachments

        1. 0.4.15-dev-3380-gab7b004_affected.log
          104 kB
          reactosfanboy
        2. 0.4.15-dev-3380-gab7b004_affected.webm
          1.22 MB
          reactosfanboy

        Issue Links

          blocks

          Sub-task - The sub-task of the issue CORE-7684 Zip folder namespace extension

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-11238 ReactOS Drag and Drop issues

          • Major - Major loss of function.
          • Untriaged
          is duplicated by

          New Feature - A new feature of the product, which has yet to be developed. CORE-16241 Drag-n-drop from .zip archives

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. CORE-19021 Dropping a file from inside Zip Folder should unzip the file

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          New Feature - A new feature of the product, which has yet to be developed. CORE-19020 Dropping files into Zip Folder should compress the dropped files

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            People

              Unassigned Unassigned
              reactosfanboy reactosfanboy
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: