Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18264

Incorrect behavior of GetCurrencyFormatW/GetNumberFormatW with regard of the "grouping" parameter

    XMLWordPrintable

Details

    Description

      Using : reactos-bootcd-0.4.15-dev-4914-g2220e56-x86-gcc-lin-dbg

      GetCurrencyFormatW does NOT behave as expected with regard to the "grouping" parameter. I've not explored other settings (in particular negative formating, ...) but it seems that the current implementation is incorrect. 

      Impact : GetCurrencyFormatW is typically used in Finance/Money management software to have specific numbers formatting.

      This API was improved in the past by CORE-17009 in order to correctly behave for the "standards" format used in the CPL, but this was not enougth

      Attached to this issue a screenshot and the small test app i've written to reproduce the case.

      Guilty Code: https://github.com/reactos/reactos/blob/master/dll/win32/kernel32/winnls/string/lcformat.c#L1804

      Note : GetNumberFormatW is suffering from a similar weakness with a rather dirty hack for the "32" grouping case, see lcformat.c / https://github.com/reactos/reactos/blob/master/dll/win32/kernel32/winnls/string/lcformat.c#L1394

      Wine 10.9 is NOT affected, in particular following this commit https://github.com/wine-mirror/wine/commit/9afc20949a4d63c4d1323683aeda4f7af13f3969

      Attachments

        Activity

          People

            Unassigned Unassigned
            KRosUser KRosUser
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: