Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18270

RAPPS fails to format error message when network is down and misses MessageBox to the user

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • None

    Description

      Using : reactos-bootcd-0.4.15-dev-4914-g2220e56-x86-gcc-lin-dbg

      • Open RAPPS
      • Unplug network cable
      • Download and app

      Fails (as expected) but RAPPS fails to properly format the error message and logs says : loaddlg.cpp:548: (base/applications/rapps/loaddlg.cpp:548) FormatMessageW unexpected failure (err 1813)

      as a consequence no error message is shown to the user as MessageBoxW(hWndOwner, lpMsg, NULL, MB_OK | MB_ICONERROR); is not executed

       

      Culprit code section :

      if (!FormatMessageW(FORMAT_MESSAGE_ALLOCATE_BUFFER |
      FORMAT_MESSAGE_IGNORE_INSERTS |
      (bInetError ? FORMAT_MESSAGE_FROM_HMODULE : FORMAT_MESSAGE_FROM_SYSTEM),
      (bInetError ? GetModuleHandleW(L"wininet.dll") : NULL),
      dwLastError,
      LANG_USER_DEFAULT,
      (LPWSTR)&lpMsg,
      0, NULL))

      { DPRINT1("FormatMessageW unexpected failure (err %d)\n", GetLastError()); return FALSE; }

       

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              KRosUser KRosUser
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: