Details
-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
None
Description
Using : reactos-bootcd-0.4.15-dev-4914-g2220e56-x86-gcc-lin-dbg
- Open RAPPS
- Unplug network cable
- Download and app
Fails (as expected) but RAPPS fails to properly format the error message and logs says : loaddlg.cpp:548: (base/applications/rapps/loaddlg.cpp:548) FormatMessageW unexpected failure (err 1813)
as a consequence no error message is shown to the user as MessageBoxW(hWndOwner, lpMsg, NULL, MB_OK | MB_ICONERROR); is not executed
Culprit code section :
if (!FormatMessageW(FORMAT_MESSAGE_ALLOCATE_BUFFER |
FORMAT_MESSAGE_IGNORE_INSERTS |
(bInetError ? FORMAT_MESSAGE_FROM_HMODULE : FORMAT_MESSAGE_FROM_SYSTEM),
(bInetError ? GetModuleHandleW(L"wininet.dll") : NULL),
dwLastError,
LANG_USER_DEFAULT,
(LPWSTR)&lpMsg,
0, NULL))
Attachments
Issue Links
- is blocked by
-
CORE-17377 WinInet library is missing message table
- Open
-
CORE-17375 Regression: if no network adapters are available, rapps will display wrong error message
- Resolved
- relates to
-
CORE-19490 Rapps: Improve and refactor
- Open