Description
Using reactos-bootcd-0.4.15-dev-5186-gbbef618-x86-gcc-lin-dbg
"My Computer" > Arrange Icons by "Comment"
"Recycle Bin" > Arrange Icons by "Type" or "Modified"
"Explorer" > Arrange Icons by "Attributes" or "Comments"
"Printer" > Arrange Icons by "Location" or "Models"
"Network Connections" > Arrange Icons by "Phone number, Owner" (see CORE-19099)
Requires fixes in CompareIDs and GetDetailsOf functions
Similar to CORE-17269 but now with "Comment"
- Sort using column header works fine
- Sort using context menu (or "View > Sort by" menu) has no effect. Expected behavior : sorting like click on column header does.
See video : ROS-screen0.webm
Related to CORE-11776, faulty code is : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CDefView.cpp;hb=5c2ec83fa7658fb472313e094f7a29a216fe16b1#l1913 where CDefview only supports the first 4 columns as per :
/* the menu-ID's for sorting are 0x30... see shrec.rc */ |
case 0x30: |
case 0x31: |
case 0x32: |
case 0x33: |
m_sortInfo.nHeaderID = dwCmdID - 0x30; |
m_sortInfo.bIsAscending = TRUE;
|
_Sort();
|
break; |
If should store the "range" of ArrangeItems from CDefView::InitList()
Log says :
err:(dll/win32/shell32/CDefViewBckgrndMenu.cpp:282) Got unknown command id 51l |
CDefView.cpp:1523: Unexpected failure (hr)=80004005 |
Attachments
Issue Links
- is duplicated by
-
CORE-19099 Network Connections, "Sort by" context menu does not work
- Resolved
- relates to
-
CORE-19329 [SHELL32] Right clicking the header section in explorer filebrowsers details-view should have a menu to select the columns
- Resolved
-
CORE-17269 [FIXED] Sort by Free Space in My Computer fails when using context menu but works when clicking on menu header
- Resolved