Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18587

[SYSSETUP] During the setup our combobox for the timezone is too small, Vienna calling!

    XMLWordPrintable

Details

    Description

      During the setup our combobox for the timezone is too small to hold the longest string
      for GMT+1 ("Amsterdam, Berlin, ...., Vienna").
      So that "Vienna" is cropped unintentionally.
      As far as I have checked, GMT+1 is the longest string ever used in there.

      Observed result
      0.4.15-dev-5324-gd035452_comboBoxIsTooSmall.png
      0.4.15-dev-5324-gd035452_comboBoxIsTooSmall.log

      Expected result
      2K3DC_SP2_eng_StringFits.png
      for the record: even in ros'es own datetime.cpl the combobox is significantly larger and the whole string fits into it, so we could theoretically pick the length from there, and apply it in a way that the syssetup dialog still looks good from an aesthetics point of view.

      I tested ros in german localization here, I would guess that it also doesn't fit in the english version, but we should enlarge for it being big enough for the localization that uses the longest string.

      For the record: This is broken down into SVN stone age definitely. I never remembered it being big enough for that string. I was just too lazy to file a ticket for it up to now.

      Attachments

        1. 0.4.15-dev-5324-gd035452_comboBoxIsTooSmall.log
          61 kB
          reactosfanboy
        2. 0.4.15-dev-5324-gd035452_comboBoxIsTooSmall.png
          16 kB
          reactosfanboy
        3. 2K3DC_SP2_eng_StringFits.png
          43 kB
          reactosfanboy
        4. patched.webm
          790 kB
          reactosfanboy

        Activity

          People

            reactosfanboy reactosfanboy
            reactosfanboy reactosfanboy
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: