Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18745

A WIN32SS bug leads to issues and freezes in my poorly-written desk.cpl

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • Win32SS
    • None

    Description

      I am a huge fan of the following commit 0.4.15-dev-5495-g71123b7 so I experimented with porting it back, since the older releases 0.4.7-0.4.14 are all affected by the 2 glitches:

      • 2 handle leaks
      • the screensaver not restarting its preview after the screensaver options subdialog has been opened once

      The porting back went well. Meaning that:
      The resulting binary desk.cpl runs perfectly like I would expect it to behave on XPSP3. I can open the screensaver options subdialog, then close it again, no leaks, and the preview will be shown properly
      However if I run the exact same binary in current ros master head 0.4.15-dev-5517-g9762ef9 and open the screensaver options subdialog, then exactly when I close it, then the whole desk.cpl and even other parts of the OS will freeze almost to death and I will see 100% CPU load in rundll32.exe (which is hosting the desk.cpl)

      Some of binarymaster changes to desk.cpl with the ownerdrawn drawing do hide that issue in Win32SS in the desk.cpl of master head. But after a proper fix in Win32SS, the attached binary must work as well!
      Therefore please do not use the ros inbuilt desk.cpl to test this issue, but use my attached desk.cpl and (in case you need them) the desk_sources.zip.

      That is a bug in Win32SS in ros

      I bet it is related to the following loggings that do get generated when hovering my mouse over the preview:

      (win32ss/user/ntuser/msgqueue.c:2027) err: Thread Q is locked to ptiSysLock 0xB17C57E0 pti 0xB17E6008
      (win32ss/user/ntuser/message.c:946) err: Message WM_PAINT count 0 Internal Paint Set? FALSE
      (win32ss/user/ntuser/input.c:601) err: Attach Free! ptiFrom 0xB17C57E0  ptiTo 0xB17E6008 paiCount 0
      

      Attachments

        1. 0.4.15-dev-5517-g9762ef9_affected.log
          2.13 MB
        2. 0.4.15-dev-5517-g9762ef9_regular_deskCpl_affected_as_well.webm
          457 kB
        3. 15-6369-3dtext-scr.log
          65 kB
        4. cpl_screensaver.patch
          0.6 kB
        5. crash.log
          68 kB
        6. desk_sources.zip
          204 kB
        7. desk.cpl
          552 kB
        8. ReactOS-15-6369.webm
          1.73 MB
        9. screenSaver-fix-01.patch
          1 kB
        10. screenSaver-fix-03.patch
          1 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              reactosfanboy reactosfanboy
              Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: