Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18758

PDFSam 3.3.5 from RAPPS - Installer showing a cdrom drive for Disk Costing again, while it shouldn't

    XMLWordPrintable

Details

    Description

      reactos-bootcd-0.4.15-dev-5517-g9762ef9-x86-gcc-lin-dbg

      PDFSam 3.3.5 from RAPPS

       MSI Disk Costing show the same data for C: (HDD)... and D: (only if cd-rom drive is empty)

      but...

       works fine is a CD is inserted in drive :

      the new code : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/msi/dialog.c#l3309 is now working as expected when a CD Rom Drive is empty. The code does not check the return value of GetDiskFreeSpaceExW which may fail and the "free" variable is then used while it should it (using previous data)

       Patch fixing the bug (tested ) : fix.patch

       WinXPSP3 : 

       Other MSI Disk Costing issues : CORE-18749CORE-17833

       Reported upstream to Wine : https://bugs.winehq.org/show_bug.cgi?id=54160

      Attachments

        1. fix.patch
          1 kB
          KRosUser
        2. image-2022-12-15-13-13-40-404.png
          24 kB
          KRosUser
        3. image-2022-12-15-13-22-39-949.png
          14 kB
          KRosUser
        4. image-2022-12-15-19-26-04-634.png
          16 kB
          KRosUser
        5. image-2022-12-15-19-39-06-015.png
          16 kB
          KRosUser
        6. image-2022-12-15-20-38-37-982.png
          20 kB
          KRosUser
        7. putty.log
          215 kB
          KRosUser

        Activity

          People

            learn_more Mark Jansen
            KRosUser KRosUser
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: