Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19019

Address edit box breaks after going to the same path twice

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.15
    • Shell
    • None

    Description

      Steps to reproduce:

      1. Launch the filebrowser
      2. Open any directory
      3. Press the Go button twice
      4. The address bar is now broken - no matter what path is inputed into the address edit box, pressing Go does nothing.

      The bug does not occur when using the ReactOS filebrowser with browseui.dll from Windows XP. The bug does occur on Windows when using the ReactOS filebrowser and browseui.dll.

      The bug seems to be caused by the fact, that if there's a match on line 324, then pidlLastParsed stays non-NULL. In subsequent calls to CAddressEditBox::Execute, pidlLastParsed is then non-NULL, and as such, condition on line 286 is false, and because of that the address never gets re-parsed.

       

      Attachments

        1. gopidlparsed_v2.patch
          1 kB
          KRosUser
        2. gopidlparsed.patch
          0.5 kB
          KRosUser

        Issue Links

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              thennx thennx
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: