Description
reactos-bootcd-0.4.15-dev-6546-gaa719b9-x86-gcc-lin-dbg
- Open explorer, "go" button is visible
- Right click on toolbar
- "go button" is checked (correct, as visible)
- click on "go button" in popup menu
- "go button" is removed from toolbar (as expected)
- "go button" is checked (incorrect, as NOT visible)
- expected result : "go button" not checked when removed
Cause is likely : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/browseui/internettoolbar.cpp#l1731 where goButtonChecked read "ShowGoButton" as a boolean with SHRegGetBoolUSValueW, while it's saved as "yes"/"no" string with SHRegSetUSValueW here : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/browseui/addressband.cpp#l311
Problem is that "check" is only set when explorer is started, pSettings->fShowGoButton is not refreshed
Fixed by : go.patch