Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19414

Wrong error message when failling to move a folder

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • 0.4.15
    • Shell
    • None

    Description

      reactos-bootcd-0.4.15-dev-7374-g88107ad-x86-gcc-lin-dbg

      • Open "MyComputer"
      • Drop'n'drop "C:" drive onto Desktop:

      Error message is supposed to indicate the failing path as per : IDS_MOVEERRORSUBFOLDER where %s is replaced by feFrom->szFilename in validate_operation here https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/shlfileop.cpp;hb=6c93f3ca6b95fa5e1806fc29295d3bc8ada979f9#l2010 

      Note : Same with "same path"

      This is due to the case in add_file_to_entry where only feFile->szFullPath gets populated but neither feFile->szDirectory nor feFile->szFilename due to ptr being null, which is the expected case for "C:\" path.

      Fixed by copyerrorfix.patch

      Attachments

        1. copyerrorfix_v2.patch
          2 kB
          KRosUser
        2. copyerrorfix.patch
          3 kB
          KRosUser
        3. image-2024-01-03-16-01-11-607.png
          31 kB
          KRosUser
        4. image-2024-01-03-16-17-59-835.png
          8 kB
          KRosUser
        5. image-2024-01-04-19-30-10-097.png
          33 kB
          KRosUser
        6. image-2024-01-04-19-30-27-777.png
          18 kB
          KRosUser
        7. putty.log
          40 kB
          KRosUser

        Activity

          People

            katayama_hirofumi_mz Katayama Hirofumi MZ
            KRosUser KRosUser
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: