Description
reactos-bootcd-0.4.16-dev-544-gaebaa14-x86-gcc-lin-dbg
- Open control panel
- Drag'n'drop an element to the Desktop to create shortcut
- Open this shortcut properties and attempt to change icon
Fails, does nothing and logs
err:(win32ss/user/user32/windows/message.c:1556) Exception Dialog unicode 7AF754EC Msg 273 pti B40B4008 Wndpti B40B4008 |
- Same problem if doing this on a "My Computer" element shortcut on Desktop
and similarly, changing Normal Window to another mode, or attempting to define a shortcut leads to this error when applying : L"The specified file name in the target box is invalid"
Related to CORE-19825
Code of interest: CShellLink::OnCommand in dll/win32/shell32/CShellLink.cpp https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CShellLink.cpp;hb=eafa7c68b61ce250aee7c7a0cb498a80f1e2a17b#l2916 in particular not checking return value of FindExecutableW which likely fails (and function should exit in such a case).