Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-3655

Windmc uses host newlines instead of \r\n, but code depends on \r\n

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: NTCore
    • Labels:
      None
    • Environment:

      Operating System: ReactOS
      Platform: x86 Hardware

      Description

      Incompatibility between Win32CsrHardError and WMC regarding "\r\n" and "\n".

      1. subsystems/win32/csrss/win32csr/dllmain.c: (Win32CsrHardError function, ~line 380)
      CaptionSize += 3; // "}\r\n" - 3

      2. obj-i386/include/reactos/mc/ntstatus.rc: (line 1149)
      "

      {Unable To Locate Component}

      \nThis application has failed to start becau",

      So, WMC generates .rc file that results in single "\n" in the messages. But Win32CsrHardError expects "\r\n" and I see error messages without the first symbol ("his application has failed to start because...").

      I don't know whether there are another dependencies on "\r\n" in the kernel, but I think WMC should be fixed to write "\r\n" into the messages.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                AmineKhaldi AmineKhaldi
                Reporter:
                aspotashev aspotashev
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: