Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-5420

wmc doesn't handle unix newlines correctly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Fix Version/s: 0.4.0
    • Component/s: Win32SS
    • Labels:
      None
    • Environment:

      Operating System: ReactOS
      Platform: x86 Hardware

      Description

      Load an application that requires a missing Dll (for instance IrfanView 4.28 Setup which needs MFC42.DLL).
      The error message will be truncated to something like "This application has failed to start because MC2D".

      (Possibly, but probably not, related to CORE-5414)

      win32csr.dll's CsrpFormatMessages function calls StringCbPrintfW with %hs in the format string in this case to create this message. The underlying _vsnwprintf function relies on mbtowc, which is implemented incorrectly using RtlMultiByteToUnicodeN (incompatible return values) in lib\sdk\crt\string\mbstowcs_nt.c and thus causes it to skip characters.

      I'll be looking for a fix later; unless someone else has an idea first, of course

        Attachments

        1. erransiuni.patch
          1 kB
        2. errcodes.patch
          0.8 kB
        3. mbtowc.patch
          2 kB
        4. mbtowc2.patch
          1 kB
        5. truncated _text.png
          truncated _text.png
          26 kB
        6. wmc.patch
          2 kB

          Issue Links

            Activity

              People

              • Assignee:
                ThePhysicist Timo Kreuzer
                Reporter:
                ThFabba ThFabba
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: