Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-7292

cppcheck checks of ReactOS code

    XMLWordPrintable

Details

    • Task
    • Resolution: Duplicate
    • Major
    • None
    • None
    • None

    Description

      Here are checks of ReactOS code done with the latest version of cppcheck, the cppcheck-1.60.1-x86.

      They are sorted by types (errors, warnings, ...)

      Also, they may be more accurate than the one from our site, http://fezile.reactos.org/cppcheck/

      Albeit most of the errors / warnings come from 3rd-party code (or wine dlls), some are in our side.

      Attachments

        1. 59430.zip
          1.16 MB
        2. 59938.zip
          1.22 MB
        3. 70214.zip
          1.00 MB
        4. ntvdm_59425.zip
          240 kB
        5. ntvdm_59962.zip
          974 kB
        6. ROS_ERROR_cppcheck_1file.zip
          481 kB
        7. ROS_ERROR_cppcheck.zip
          494 kB

        Issue Links

          duplicates

          Task - A task that needs to be done. CORE-12334 Address issues found by cppcheck 1.76.1 on r73189

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-8978 [CPPCHECK] Array index used before limits check.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          1.
          		 fontview: Unnecessary malloc before using GetWindowLongPtr Sub-task Closed Bug Zilla
          2.
          		 notepad: Possibly uninitialized variable being freed Sub-task Closed ThFabba
          3.
          		 notepad: Function that relies on trailing null might have been called with non null terminated string Sub-task Resolved Bug Zilla
          4.
          		 svchost: Function that relies on trailing null might have been called with non null terminated string Sub-task Closed ThFabba
          5.
          		 cmd: memory leak on failure case Sub-task Closed AmineKhaldi
          6.
          		 cmd: Incorrect usage of realloc Sub-task Resolved Bug Zilla
          7.
          		 explorer: Incorrect usage of realloc Sub-task Resolved Bug Zilla
          8.
          		 Undefined behavior, sprintf parameter used as destination Sub-task Closed Bug Zilla
          9.
          		 iphlpapi: Possibly uninitialized variables used. Sub-task Resolved Bug Zilla
          10.
          		 kernel32: Possibly uninitialized variables used. Sub-task Resolved Bug Zilla
          11.
          		 lsasrv: Possibly uninitialized variable used Sub-task Closed Bug Zilla
          12.
          		 mciavi32: uninitialized variable returned Sub-task Closed Bug Zilla
          13.
          		 mscoree: Unitialized variable being freed Sub-task Closed Bug Zilla
          14.
          		 crt: incorrect usage of realloc Sub-task Closed Bug Zilla
          15.
          		 cabman: memory leaks in failure paths Sub-task Resolved ThFabba
          16.
          		 cmd_utils/sort: Memory leak: list Sub-task Resolved Bug Zilla
          17.
          		 notepad: possible memory leaks Sub-task Resolved Bug Zilla
          18.
          		 cmd: mismatching allocation and deallocation Sub-task Resolved ThFabba
          19.
          		 icmp: memory/socket leak on failure path Sub-task Resolved ThFabba
          20.
          		 kernel32: returning/dereferencing variable after it is deallocated/released Sub-task Resolved Bug Zilla
          21.
          		 ndisuio: memory leak on failure path Sub-task Resolved AmineKhaldi
          22.
          		 sysaudio: Memory leak on failure path Sub-task Resolved AmineKhaldi
          23.
          		 atl: memory leak on failure path (copy pasta?) Sub-task Resolved Bug Zilla
          24.
          		 dnslib: uninitialized variable usage Sub-task Resolved Dmitry Chapyshev
          25.
          		 crt: redundant assignment of variable to itself Sub-task Resolved gonzoMD

          Activity

            People

              vicmarcal vicmarcal
              hbelusca hbelusca
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: