Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-7292 cppcheck checks of ReactOS code
  3. CORE-7296

svchost: Function that relies on trailing null might have been called with non null terminated string

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Services
    • Labels:
      None

      Description

      CPPCHECK: base\services\svchost\svchost.c 46 error Dangerous usage of 'ServiceKeyBuffer' (strncpy doesn't always null-terminate it).

      here strncpy is used to copy a string and later strcat is used on it, which relies on the source string being null terminated.

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              encoded encoded
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: