Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-8114

Fix check priority in dbghelp

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.3.17
    • Component/s: Wine
    • Labels:

      Description

      if(... ||(sym_info->NameLen = UnDecorateSymbolName(name, sym_info->Name, sym_info->MaxNameLen, UNDNAME_NAME_ONLY) == 0))

      Because priority order, first the == check is made, and hence sys_info->NameLen will be assigned 0 or 1.
      Instead the probably expected behavior of assigning the length, and afterwards checking against 0.

      Patch attached

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              vicmarcal vicmarcal
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: