Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-8522

[PATCH]Fix registry issues with JDK and JRE setup

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.0
    • Component/s: NTCore
    • Labels:
    • Module:

      Description

      ReactOS seems to be crashing when trying to install JDK7+ and/or JRE7.

      JDK basically crashes because it installs JRE, however it won't if you remove the JRE component to be installed from the JDK.

      JDK and JRE crashes with different asserts, however the root of the issue is the same. The problem appears when a key is added under CLSID, which is known to store hundreds of keys.

      The ASSERT is basically a mix of facts:
      1) Our keys are not sorted in the memory structure, so we can't use the binary search done through CmpCompareInIndex.
      2) When there is just one leaf, the CmpFindSubKeyInLeaf is used (thankfully, otherwise we would be having asserts everywhere)
      3) When the number of entries force a split creating a second leaf, our code is using CmpCompareInIndex. However, as said, CmpCompareInIndex can just be used when, and just when, the entries are correctly sorted.
      4) The patch hence ifdefs the use of CmpCompareInIndex and "expecting sorted entries code" until we have a correct sorting mechanism.

      The patch seems to fix JRE and JDK, also the test case (which forces the creation of a second leaf) linked.

      I'm not the author of the patch, just a flying bird drop it to me.

        Attachments

        1. cm.patch
          2 kB
        2. cm.patch
          2 kB

          Issue Links

            Activity

              People

              • Assignee:
                bug zilla Bug Zilla
                Reporter:
                vicmarcal vicmarcal
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: