ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-200

reg_winetest test_add skipped because they cause exceptions in Cm

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.1
    • Component/s: Wine Tests
    • Labels:
      None

      Description

      kd> kp
      ChildEBP RetAddr  
      f95d0aec 8041fcee nt!memcpy+0x48
      f95d0b14 8040f9f6 nt!CmpSetValueDataNew(struct _HHIVE * Hive = 0xb069a008, void * Data = 0x00000000, unsigned long DataSize = 5, unsigned long StorageType = 0, unsigned long ValueCell = 0x24fe0, unsigned long * DataCell = 0xe15befec)+0xde [e:\reactos\ntoskrnl\config\cmvalue.c @ 303]
      f95d0b84 8040d738 nt!CmpSetValueKeyNew(struct _HHIVE * Hive = 0xb069a008, struct _CM_KEY_NODE * Parent = 0xe15bee24, struct _UNICODE_STRING * ValueName = 0xf95d0cc0 "bin1", unsigned long Index = 0xa, unsigned long Type = 3, void * Data = 0x00000000, unsigned long DataSize = 5, unsigned long StorageType = 0, unsigned long SmallData = 0)+0x226 [e:\reactos\ntoskrnl\config\cmapi.c @ 228]
      f95d0c58 804221b8 nt!CmSetValueKey(struct _CM_KEY_CONTROL_BLOCK * Kcb = 0xe1618dd8, struct _UNICODE_STRING * ValueName = 0xf95d0cc0 "bin1", unsigned long Type = 3, void * Data = 0x00000000, unsigned long DataLength = 5)+0x458 [e:\reactos\ntoskrnl\config\cmapi.c @ 835]
      f95d0cf4 8050b1bb nt!NtSetValueKey(void * KeyHandle = 0x0000078c, struct _UNICODE_STRING * ValueName = 0x0012fe48 "bin1", unsigned long TitleIndex = 0, unsigned long Type = 3, void * Data = 0x00000000, unsigned long DataSize = 5)+0x218 [e:\reactos\ntoskrnl\config\ntapi.c @ 719]
      f95d0d1c 8050a6cf nt!KiSystemCallTrampoline(void * Handler = 0x80421fa0, void * Arguments = 0x0012fe24, unsigned long StackBytes = 0x18)+0x1b [e:\reactos\ntoskrnl\include\internal\i386\ke.h @ 742]
      f95d0d5c 80403e23 nt!KiSystemServiceHandler(struct _KTRAP_FRAME * TrapFrame = 0xf95d0d64, void * Arguments = 0x0012fe24)+0x22f [e:\reactos\ntoskrnl\ke\i386\traphdlr.c @ 1738]
      f95d0d5c 7c92ca4e nt!KiFastCallEntry+0x8c
      WARNING: Stack unwind information not available. Following frames may be wrong.
      0012fe7c 0040179f ntdll!KiFastSystemCallRet
      0012feb4 00401cf5 reg!reg_add(unsigned short * key_name = 0x00134d48, unsigned short * value_name = 0x00134d98, int value_empty = 0n0, unsigned short * type = 0x00132350, wchar_t separator = 0x0 '', unsigned short * data = 0x00134dd0, int force = 0n1)+0x16f [e:\reactos\base\applications\cmdutils\reg\reg.c @ 330]
      0012ff1c 004025ac reg!wmain(int argc = 0n10, unsigned short ** argvW = 0x001322e8)+0x275 [e:\reactos\base\applications\cmdutils\reg\reg.c @ 525]
      0012ffb4 00402641 reg!__tmainCRTStartup(void)+0x25c [e:\reactos\lib\sdk\crt\startup\crtexe.c @ 308]
      0012ffc0 7c7cf2f2 reg!wmainCRTStartup(void)+0x21 [e:\reactos\lib\sdk\crt\startup\crtexe.c @ 196]
      0012fff0 00000000 kernel32!BaseProcessStartup(<function> * lpStartAddress = 0x00402620)+0x42 [e:\reactos\dll\win32\kernel32\client\proc.c @ 478]
      

        Issue Links

          Activity

          Hide
          Thomas Faber
          added a comment -

          This is an easy one. NtSetValueKey doesn't check for Data=NULL && DataSize != 0. Any volunteers?

          Show
          Thomas Faber
          added a comment - This is an easy one. NtSetValueKey doesn't check for Data=NULL && DataSize != 0. Any volunteers?
          Hide
          victor martinez calvo
          added a comment -

          Me.

          Show
          victor martinez calvo
          added a comment - Me.
          Hide
          Thomas Faber
          added a comment -

          Thanks
          Actually, I don't see why Data == NULL is special-cased at all. Just removing that check might do the trick.

          Show
          Thomas Faber
          added a comment - Thanks Actually, I don't see why Data == NULL is special-cased at all. Just removing that check might do the trick.
          Hide
          Thomas Faber
          added a comment - - edited

          I'd like to get this into the next release. Please assign to me if you don't think you'll get to it in the next month or two, or ping me if you have any problems with it. Thanks.

          Show
          Thomas Faber
          added a comment - - edited I'd like to get this into the next release. Please assign to me if you don't think you'll get to it in the next month or two, or ping me if you have any problems with it. Thanks.
          Hide
          Mark Jansen
          added a comment - - edited

          Thomas Faber, the test does not seem to crash locally without a patch, is there some special precondition to trigger this crash?
          (using set WINETEST_INTERACTIVE=1)

          Show
          Mark Jansen
          added a comment - - edited Thomas Faber , the test does not seem to crash locally without a patch, is there some special precondition to trigger this crash? (using set WINETEST_INTERACTIVE=1)
          Hide
          Thomas Faber
          added a comment -

          Looks like the conditions for this bug to occur are:

          • DataSize must be larger than 4
          • The value must not already exist

          I'll adjust my test accordingly.

          Show
          Thomas Faber
          added a comment - Looks like the conditions for this bug to occur are: DataSize must be larger than 4 The value must not already exist I'll adjust my test accordingly.

            People

            • Assignee:
              Thomas Faber
              Reporter:
              Amine Khaldi
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile