ReactOS Test Suite
  1. ReactOS Test Suite
  2. ROSTESTS-226

PATCH: DnsQuery_A testcase to show how it doesnt resolve IP for hostname

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: ReactOS Tests
    • Labels:

      Description

      DnsQuery_A fails to resolve the IP for hostname.
      Testcase just picks the hostname via gethostname, and feeds with it DnsQuery_A.
      It fails in ReactOS while works in Windows.

      1. DnsQueryA.patch
        4 kB
        victor martinez calvo
      2. DnsQueryA.patch
        4 kB
        victor martinez calvo
      3. DnsQueryA.patch
        3 kB
        victor martinez calvo

        Activity

        Hide
        victor martinez calvo
        added a comment -

        With patches from CORE-10533 the issue is fixed as reported in CORE-11394 by hater

        Show
        victor martinez calvo
        added a comment - With patches from CORE-10533 the issue is fixed as reported in CORE-11394 by hater
        Hide
        victor martinez calvo
        added a comment -

        More tests

        Show
        victor martinez calvo
        added a comment - More tests
        Hide
        Thomas Faber
        added a comment -

        "Applications must free returned RR sets with the DnsRecordListFree function."

        victor martinez calvo, could you fix those memory leaks accordingly? Thanks

        Show
        Thomas Faber
        added a comment - "Applications must free returned RR sets with the DnsRecordListFree function." victor martinez calvo , could you fix those memory leaks accordingly? Thanks
        Hide
        victor martinez calvo
        added a comment -

        Thomas Faber, sorry I missed your comment. Here you are, with the frees fixed.

        Btw, just as a remark, I am using DnsFreeRecordList to free it, which is the proper one according to the DNS_FREE_TYPE enumeration documentation: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682056(v=vs.85).aspx

        However seems there is a MSDN example using DnsFreeRecordListDeep which is not documented ( https://support.microsoft.com/en-us/kb/831226 )

        We don't handle DnsFreeRecordListDeep in our code but maybe you would like to add a #define DnsFreeRecordListDeep DnsFreeRecordList as Despotify project does ( https://github.com/SimonKagstrom/despotify/blob/master/src/lib/dns.c )

        Show
        victor martinez calvo
        added a comment - Thomas Faber , sorry I missed your comment. Here you are, with the frees fixed. Btw, just as a remark, I am using DnsFreeRecordList to free it, which is the proper one according to the DNS_FREE_TYPE enumeration documentation: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682056(v=vs.85).aspx However seems there is a MSDN example using DnsFreeRecordListDeep which is not documented ( https://support.microsoft.com/en-us/kb/831226 ) We don't handle DnsFreeRecordListDeep in our code but maybe you would like to add a #define DnsFreeRecordListDeep DnsFreeRecordList as Despotify project does ( https://github.com/SimonKagstrom/despotify/blob/master/src/lib/dns.c )
        Hide
        Thomas Faber
        added a comment -

        -Deep is an obsolete Win2k constant, as documented in PSDK's windns.h

        Show
        Thomas Faber
        added a comment - -Deep is an obsolete Win2k constant, as documented in PSDK's windns.h

          People

          • Assignee:
            Thomas Faber
            Reporter:
            victor martinez calvo
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile