Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10143

rapps: blue rect

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.3
    • Component/s: None
    • Labels:
    • Environment:

      r69118

      Description

      When ReactOS Application Manager is started, you can find strange visual glitch: blue rectangle after reactos.org hyperlink (look at the screenshot).

      After some research, I have discovered that this problem have two sources:
      1. In rapps.exe. This rectangle is text selection. Not usual selection - this is selected null character. Edit control, which is used in rapps, RichEdit20W, allows this behavior.
      2. In riched20.dll. When you start rapps in Windows, there is no blue rectangle. This happens because RichEdit control is not focused, and thus it's selection is invisible. Wine's riched20 don't follows this convention.

      I think both this problems needs to be fixed.
      1. Rapps logic can be easily corrected. Please, look at the proposed patch.
      2. Riched20 is harder to fix. I don't know how to do this, but I've made the test program. Sources and exe are attached.

        Attachments

        1. rapps_blue_rect.png
          rapps_blue_rect.png
          69 kB
        2. rapps_sel_fix.diff
          0.8 kB
        3. RichEditSelTest_bad.png
          RichEditSelTest_bad.png
          3 kB
        4. RichEditSelTest_good.png
          RichEditSelTest_good.png
          11 kB
        5. RichEditSelTest_src.zip
          1 kB
        6. RichEditSelTest.exe
          95 kB

          Issue Links

            Activity

              People

              • Assignee:
                bug zilla Bug Zilla
                Reporter:
                Vort Vort
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: